vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix packed-not-aligned error on GCC 8

Browse source 
When building with GCC 8, there are several errors regarding packed-not-aligned.

./include/grub/gpt_partition.h:79:1: error: alignment 1 of ‘struct grub_gpt_partentry’ is less than 8 [-Werror=packed-not-aligned]

This patch fixes the build error by cleaning up the ambiguity of placing
aligned structure in a packed one. In "struct grub_btrfs_time" and "struct
grub_gpt_part_type", the aligned attribute seems to be superfluous, and also
has to be packed, to ensure the structure is bit-to-bit mapped to the format
laid on disk. I think we could blame to copy and paste error here for the
mistake. In "struct efi_variable", we have to use grub_efi_packed_guid_t, as
the name suggests. :)

Signed-off-by: Michael Chang <mchang@suse.com>
Tested-by: Michael Chang <mchang@suse.com>
Tested-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Michael Chang 2018-03-26 16:52:34 +08:00 committed by Vincent Batts
parent 77dd0afe57
commit e416c1036f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/grub/gpt_partition.h
View file

@ -91,7 +91,7 @@ struct grub_gpt_header
struct grub_gpt_partentry
{
grub_gpt_part_type_t type;
grub_gpt_guid_t type;
grub_gpt_guid_t guid;
grub_uint64_t start;
grub_uint64_t end;