vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

tcp: ack when we get an OOO/lost packet

Browse source 
While adding tcp window scaling support I was finding that I'd get some packet
loss or reordering when transferring from large distances and grub would just
timeout.  This is because we weren't ack'ing when we got our OOO packet, so the
sender didn't know it needed to retransmit anything, so eventually it would fill
the window and stop transmitting, and we'd time out.  Fix this by ACK'ing when
we don't find our next sequence numbered packet.  With this fix I no longer time
out.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
This commit is contained in:
Josef Bacik 2015-08-12 08:16:22 -07:00 committed by Andrei Borzenkov
parent a03c1034f6
commit fb47807918
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
grub-core/net/tcp.c
View file

@ -893,7 +893,10 @@ grub_net_recv_tcp_packet (struct grub_net_buff *nb,
grub_priority_queue_pop (sock->pq); grub_priority_queue_pop (sock->pq);
} }
if (grub_be_to_cpu32 (tcph->seqnr) != sock->their_cur_seq) if (grub_be_to_cpu32 (tcph->seqnr) != sock->their_cur_seq)
{
ack (sock);
return GRUB_ERR_NONE; return GRUB_ERR_NONE;
}
while (1) while (1)
{ {
nb_top_p = grub_priority_queue_top (sock->pq); nb_top_p = grub_priority_queue_top (sock->pq);