grub/grub-core/fs
Peter Jones 3f05d693d1 malloc: Use overflow checking primitives where we do complex allocations
This attempts to fix the places where we do the following where
arithmetic_expr may include unvalidated data:

  X = grub_malloc(arithmetic_expr);

It accomplishes this by doing the arithmetic ahead of time using grub_add(),
grub_sub(), grub_mul() and testing for overflow before proceeding.

Among other issues, this fixes:
  - allocation of integer overflow in grub_video_bitmap_create()
    reported by Chris Coulson,
  - allocation of integer overflow in grub_png_decode_image_header()
    reported by Chris Coulson,
  - allocation of integer overflow in grub_squash_read_symlink()
    reported by Chris Coulson,
  - allocation of integer overflow in grub_ext2_read_symlink()
    reported by Chris Coulson,
  - allocation of integer overflow in read_section_as_string()
    reported by Chris Coulson.

Fixes: CVE-2020-14309, CVE-2020-14310, CVE-2020-14311

Signed-off-by: Peter Jones <pjones@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
2020-07-29 16:55:47 +02:00
..
zfs malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
affs.c calloc: Use calloc() at most places 2020-07-29 16:55:47 +02:00
afs.c Leverage BFS implementation to read AFS. 2011-10-30 16:10:18 +01:00
archelp.c archelp: Never pass NULL as mtime. 2015-07-27 13:19:02 +02:00
bfs.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
btrfs.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
cbfs.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
cpio.c Add gcc_struct to all packed structures when compiling with mingw. 2013-12-15 14:14:30 +01:00
cpio_be.c Add gcc_struct to all packed structures when compiling with mingw. 2013-12-15 14:14:30 +01:00
cpio_common.c cpio: Disable gcc9 -Waddress-of-packed-member 2019-04-23 11:37:08 +02:00
exfat.c exfat reader 2011-04-11 18:13:00 +02:00
ext2.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
f2fs.c f2fs: Disable gcc9 -Waddress-of-packed-member 2019-06-03 11:18:31 +02:00
fat.c fat: Support file modification times 2020-03-10 21:52:07 +01:00
fshelp.c fshelp: Add handling of "." and ".." and grub_fshelp_find_file_lookup. 2015-07-27 12:45:35 +02:00
hfs.c calloc: Use calloc() at most places 2020-07-29 16:55:47 +02:00
hfsplus.c calloc: Use calloc() at most places 2020-07-29 16:55:47 +02:00
hfspluscomp.c Make grub_zlib_decompress handle incomplete chunks. 2013-12-18 23:39:49 +01:00
iso9660.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
jfs.c jfs: Disable gcc9 -Waddress-of-packed-member 2019-04-23 11:37:08 +02:00
minix.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
minix2.c Split minix.mod into minix.mod and minix2.mod. 2010-09-08 19:13:48 +02:00
minix2_be.c Handle big-endian minixfs (fixes minixfs tests on bigendian). 2012-04-01 21:35:18 +02:00
minix3.c minix3fs support 2011-04-11 08:16:13 +02:00
minix3_be.c Handle big-endian minixfs (fixes minixfs tests on bigendian). 2012-04-01 21:35:18 +02:00
minix_be.c Handle big-endian minixfs (fixes minixfs tests on bigendian). 2012-04-01 21:35:18 +02:00
newc.c Add gcc_struct to all packed structures when compiling with mingw. 2013-12-15 14:14:30 +01:00
nilfs2.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
ntfs.c calloc: Use calloc() at most places 2020-07-29 16:55:47 +02:00
ntfscomp.c Fix warnings when compiling with -O3 2016-02-17 17:56:41 +01:00
odc.c Add gcc_struct to all packed structures when compiling with mingw. 2013-12-15 14:14:30 +01:00
proc.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
reiserfs.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
romfs.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
sfs.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
squash4.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
tar.c calloc: Use calloc() at most places 2020-07-29 16:55:47 +02:00
udf.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00
ufs.c Change fs functions to add fs_ prefix 2019-04-09 10:03:29 +10:00
ufs2.c automake commit without merge history 2010-05-06 11:34:04 +05:30
ufs_be.c Support big-endian UFS1. 2012-12-08 20:56:58 +01:00
xfs.c malloc: Use overflow checking primitives where we do complex allocations 2020-07-29 16:55:47 +02:00