42acdd3b40
We are often bothered by this sort of lvm warning while running grub-install every now and then: File descriptor 4 (/dev/vda1) leaked on vgs invocation. Parent PID 1991: /usr/sbin/grub2-install The requirement related to the warning is dictated in the lvm man page: "On invocation, lvm requires that only the standard file descriptors stdin, stdout and stderr are available. If others are found, they get closed and messages are issued warning about the leak. This warning can be suppressed by setting the environment variable LVM_SUPPRESS_FD_WARNINGS." While it could be disabled through settings, most Linux distributions seem to enable it by default and the justification provided by the developer looks to be valid to me: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=466138#15 Rather than trying to close and reopen the file descriptor to the same file multiple times, which is rather cumbersome, for the sake of no vgs invocation could happen in between. This patch enables the close-on-exec flag (O_CLOEXEC) for new file descriptor returned by the open() system call, making it closed thus not inherited by the child process forked and executed by the exec() family of functions. Fixes Debian bug #466138. Signed-off-by: Michael Chang <mchang@suse.com> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> |
||
|---|---|---|
| .. | ||
| blocklist.c | ||
| emunet.c | ||
| getroot.c | ||
| hostdisk.c | ||
| ofpath.c | ||
| platform.c | ||