From 04b31893779b43be6ebae6fac5f8120ecaff1708 Mon Sep 17 00:00:00 2001 From: Pierrick HYMBERT Date: Sat, 24 Feb 2024 19:07:45 +0100 Subject: [PATCH] server: logs: PR feedback on log level --- examples/server/server.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/examples/server/server.cpp b/examples/server/server.cpp index 361f4b801..ed574344c 100644 --- a/examples/server/server.cpp +++ b/examples/server/server.cpp @@ -760,7 +760,7 @@ struct llama_server_context img_sl.img_data = clip_image_u8_init(); if (!clip_image_load_from_bytes(image_buffer.data(), image_buffer.size(), img_sl.img_data)) { - LOG_WARNING("failed to load image", { + LOG_ERROR("failed to load image", { {"slot_id", slot->id}, {"img_sl_id", img_sl.id} }); @@ -1812,7 +1812,13 @@ struct llama_server_context if (has_images && !ingest_images(slot, n_batch)) { - LOG_WARNING("failed processing images", {}); + LOG_ERROR("failed processing images", { + "slot_id", slot.id, + "task_id", slot.task_id, + }); + // FIXME @phymbert: to be properly tested + // early returning without changing the slot state will block the slot for ever + // no one at the moment is checking the return value return false; }