vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cosine similarity should be orthogonal when both vectors are zero

Browse source
This commit is contained in:
Andy Martinez 2024-12-24 12:04:47 -05:00
parent 09fe2e7613
commit 0a7a20c140
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
common/common.cpp
View file

@ -1819,11 +1819,8 @@ float common_embd_similarity_cos(const float * embd1, const float * embd2, int n
sum2 += embd2[i] * embd2[i]; sum2 += embd2[i] * embd2[i];
} }
// Handle the case where one or both vectors are zero vectors // Both vectors are required to be non-zero.
if (sum1 == 0.0 || sum2 == 0.0) { if (sum1 == 0.0 || sum2 == 0.0) {
if (sum1 == 0.0 && sum2 == 0.0) {
return 1.0f; // two zero vectors are similar
}
return 0.0f; return 0.0f;
} }