From 0d4ecfd9f4a65e1bfe5348c3bc616080b3ef29b0 Mon Sep 17 00:00:00 2001 From: ngxson Date: Tue, 25 Jun 2024 10:54:17 +0200 Subject: [PATCH] remove inverted pca hotfix --- examples/cvector-generator/pca.hpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/examples/cvector-generator/pca.hpp b/examples/cvector-generator/pca.hpp index e2af5989a..6ec3141af 100644 --- a/examples/cvector-generator/pca.hpp +++ b/examples/cvector-generator/pca.hpp @@ -299,10 +299,8 @@ static void power_iteration( //print_debug_tensor(output); ggml_gallocr_free(allocr); - // TODO @ngxson : The output vector is inverted. Don't know why, but here is quick fix - for (int i = 0; i < output->ne[0]; i++) { - ggml_set_f32_1d(output, i, -ggml_get_f32_1d(output, i)); - } + // TODO @ngxson : The output vector is randomly inverted + // Solution: https://github.com/ggerganov/llama.cpp/pull/8069#issuecomment-2185328171 } static void run_pca(