vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

actually we want eos_token in the template to infer tool call examples, explicitly skipped in new template options

Browse source
This commit is contained in:
Olivier Chafik 2025-02-03 23:52:28 +00:00
parent bc6d910f6d
commit 11c1f0c7d4
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
common/common.cpp
View file

@ -1904,10 +1904,6 @@ common_chat_templates common_chat_templates_from_model(const struct llama_model
default_template_src = CHATML_TEMPLATE_SRC; default_template_src = CHATML_TEMPLATE_SRC;
} }
} }
std::string token_bos;
std::string token_eos;
// TODO: update logic that adds BOS and EOS tokens to the tokenized prompt, in favour of the template.
#if 0
auto vocab = llama_model_get_vocab(model); auto vocab = llama_model_get_vocab(model);
const auto get_token = [&](llama_token token, const char * name, const char * jinja_variable_name) { const auto get_token = [&](llama_token token, const char * name, const char * jinja_variable_name) {
if (token == LLAMA_TOKEN_NULL) { if (token == LLAMA_TOKEN_NULL) {
@ -1920,9 +1916,8 @@ common_chat_templates common_chat_templates_from_model(const struct llama_model
return common_token_to_piece(vocab, token, true); return common_token_to_piece(vocab, token, true);
} }
}; };
token_bos = get_token(llama_vocab_bos(vocab), "BOS", "bos_token"); auto token_bos = get_token(llama_vocab_bos(vocab), "BOS", "bos_token");
token_eos = get_token(llama_vocab_eos(vocab), "EOS", "eos_token"); auto token_eos = get_token(llama_vocab_eos(vocab), "EOS", "eos_token");
#endif
try { try {
return { return {
has_explicit_template, has_explicit_template,