vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #4227 (double free in examples/train-text-from-scratch/train-text-from-scratch.cpp)

Browse source 
On commit b1108 (44c117f4) xaedes added

    ggml_allocr * alloc = NULL;

    ... (many lines in between)

    if (alloc) {
        ggml_allocr_free(alloc);
    }

Which is correct, but it's easy to lose context after many lines in between.

On commit b1287 (0e76a899) xaedes made a big change. From here on, alloc is freed eagerly.

    alloc = ggml_allocr_new(...)
    ... (short lines of code)
    ggml_allocr_free(alloc)

This happens a few times, but alloc is never set to NULL, and many lines below,
we still have

    if (alloc) {
        ggml_allocr_free(alloc);
    }

which causes a double-free.
This commit is contained in:
casavaca 2023-12-06 15:42:40 -08:00
parent 05cd6e5036
commit 27038a22d0
No known key found for this signature in database
GPG key ID: 916401545D431B19
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
examples/train-text-from-scratch/train-text-from-scratch.cpp
View file

@ -1295,10 +1295,6 @@ int main(int argc, char ** argv) {
opt_cb_data.last_save_iter = opt->iter;
}
if (alloc) {
ggml_allocr_free(alloc);
}
ggml_free(opt->ctx);
free_train_state(train);
ggml_free(model.ctx);