Apply suggestions from code review

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This commit is contained in:
Xuan Son Nguyen 2024-09-02 14:16:14 +02:00 committed by GitHub
parent fa2210652a
commit 27f2c14aa9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -92,7 +92,7 @@ struct server_task {
server_task_cmpl_type cmpl_type = SERVER_TASK_CMPL_TYPE_NORMAL; server_task_cmpl_type cmpl_type = SERVER_TASK_CMPL_TYPE_NORMAL;
// utility function // utility function
static std::unordered_set<int> get_list_id(std::vector<server_task> tasks) { static std::unordered_set<int> get_list_id(const std::vector<server_task> & tasks) {
std::unordered_set<int> ids(tasks.size()); std::unordered_set<int> ids(tasks.size());
for (size_t i = 0; i < tasks.size(); i++) { for (size_t i = 0; i < tasks.size(); i++) {
ids.insert(tasks[i].id); ids.insert(tasks[i].id);
@ -533,7 +533,7 @@ struct server_response {
waiting_task_ids.insert(id_task); waiting_task_ids.insert(id_task);
} }
void add_waiting_tasks(std::vector<server_task> & tasks) { void add_waiting_tasks(const std::vector<server_task> & tasks) {
for (const auto & t : tasks) { for (const auto & t : tasks) {
add_waiting_task_id(t.id); add_waiting_task_id(t.id);
} }