From 2c9ee7a05251d94f39c58bccdbb034eb5ecf49cc Mon Sep 17 00:00:00 2001 From: Randall Fitzgerald Date: Sun, 28 May 2023 09:34:11 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Henri Vasserman --- examples/server/server.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/server/server.cpp b/examples/server/server.cpp index ee39c8789..f84946689 100644 --- a/examples/server/server.cpp +++ b/examples/server/server.cpp @@ -32,7 +32,7 @@ struct llama_server_context llama_context *ctx; gpt_params params; - std::string stopping_word = ""; + std::string stopping_word; void rewind() { as_loop = false; @@ -255,7 +255,7 @@ struct llama_server_context std::string token_text = llama_token_to_str(ctx, token); generated_text += token_text; - for (std::string word : params.antiprompt) { + for (const std::string& word : params.antiprompt) { size_t i = generated_text.find(word, generated_text.size() - (word.size() + token_text.size())); if (i != std::string::npos) { generated_text.erase(generated_text.begin() + i, generated_text.begin() + i + word.size()); @@ -299,6 +299,7 @@ void server_print_usage(int /*argc*/, char **argv, const gpt_params ¶ms, con fprintf(stderr, " -h, --help show this help message and exit\n"); fprintf(stderr, " -t N, --threads N number of threads to use during computation (default: %d)\n", params.n_threads); fprintf(stderr, " --memory_f32 use f32 instead of f16 for memory key+value\n"); + fprintf(stderr, " -b N, --batch-size N batch size for prompt processing (default: %d)\n", params.n_batch); fprintf(stderr, " --embedding enable embedding mode\n"); fprintf(stderr, " --keep number of tokens to keep from the initial prompt (default: %d, -1 = all)\n", params.n_keep); if (llama_mlock_supported()) @@ -637,7 +638,7 @@ int main(int argc, char **argv) llama_server_context llama; params.model = "ggml-model.bin"; - std::string final_text = ""; + std::string final_text; if (server_params_parse(argc, argv, sparams, params) == false) {