From 31f153fe9caf1ba48a7337055f3c3d9eb3f86d57 Mon Sep 17 00:00:00 2001 From: Christian Zhou-Zheng Date: Thu, 30 May 2024 21:36:17 -0400 Subject: [PATCH] fix matrix transpose multiplication you have got to be kidding me --- examples/control-vector-generator/control-vector-generator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/control-vector-generator/control-vector-generator.cpp b/examples/control-vector-generator/control-vector-generator.cpp index 03e7fa5e3..57e43dcf7 100644 --- a/examples/control-vector-generator/control-vector-generator.cpp +++ b/examples/control-vector-generator/control-vector-generator.cpp @@ -276,7 +276,7 @@ static float* square_diff(callback_data & cb_data, size_t idx) { for (size_t j = 0; j < cb_data.n_embd; j++) { float sum = 0.0f; for (size_t k = 0; k < cb_data.n_tokens; k++) { - sum += cb_data.v_diff[idx][i * cb_data.n_tokens + k] * cb_data.v_diff[idx][j * cb_data.n_tokens + k]; + sum += cb_data.v_diff[idx][i + cb_data.n_embd * k] * cb_data.v_diff[idx][j + cb_data.n_embd * k]; } result[i * cb_data.n_embd + j] = sum; }