nix: clarify the meaning of "broken" and "badPlatforms"

This commit is contained in:
Someone Serge 2023-12-25 17:59:16 +00:00
parent 12115d62da
commit 42c7bbed76
No known key found for this signature in database
GPG key ID: 7B0E3B1390D61DA4

View file

@ -178,7 +178,15 @@ effectiveStdenv.mkDerivation (
}; };
meta = { meta = {
broken = (useCuda && effectiveStdenv.isDarwin) || (useMetalKit && !effectiveStdenv.isDarwin); # Configurations we don't want even the CI to evaluate. Results in the
# "unsupported platform" messages. This is mostly a no-op, because
# cudaPackages would've refused to evaluate anyway.
badPlatforms = optionals (useCuda || useOpenCL) lib.platforms.darwin;
# Configurations that are known to result in build failures. Can be
# overridden by importing Nixpkgs with `allowBroken = true`.
broken = (useMetalKit && !effectiveStdenv.isDarwin);
description = "Inference of LLaMA model in pure C/C++${descriptionSuffix}"; description = "Inference of LLaMA model in pure C/C++${descriptionSuffix}";
homepage = "https://github.com/ggerganov/llama.cpp/"; homepage = "https://github.com/ggerganov/llama.cpp/";
license = lib.licenses.mit; license = lib.licenses.mit;
@ -201,7 +209,8 @@ effectiveStdenv.mkDerivation (
SomeoneSerge SomeoneSerge
]; ];
platforms = lib.platforms.unix; # Extend `badPlatforms` instead
platforms = lib.platforms.all;
}; };
} }
) )