From 446da906d90a02b3a1d312bebe075c8213f64f7f Mon Sep 17 00:00:00 2001 From: Christian Zhou-Zheng Date: Tue, 11 Jun 2024 08:22:38 -0400 Subject: [PATCH] fix n_completions --- .../control-vector-generator/control-vector-generator.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/control-vector-generator/control-vector-generator.cpp b/examples/control-vector-generator/control-vector-generator.cpp index 07086a635..674a0ac41 100644 --- a/examples/control-vector-generator/control-vector-generator.cpp +++ b/examples/control-vector-generator/control-vector-generator.cpp @@ -538,10 +538,10 @@ static int prepare_entries(ctrl_params & cparams) { return persona + " " + suffix; // entry in positive/negative.txt must already be formatted i.e. "[INST] Act as if you're extremely happy. [/INST]" }; for (size_t i = 0; i < positive_prompts.size(); ++i) { - for (auto & cmpl : completions) { + for (size_t j = 0; j < completions.size() && j < cparams.n_completions; ++j) { // TODO replicate the truncations done by the python implementation - cparams.positive_entries.push_back(format_template(positive_prompts[i], cmpl)); - cparams.negative_entries.push_back(format_template(negative_prompts[i], cmpl)); + cparams.positive_entries.push_back(format_template(positive_prompts[i], completions[j])); + cparams.negative_entries.push_back(format_template(negative_prompts[i], completions[j])); } } return 0;