vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Attempt to remove potential TOCTOU

Browse source
This commit is contained in:
teleprint-me 2024-05-07 21:59:58 -04:00
parent f7dda38b10
commit 670e1c373b
No known key found for this signature in database
GPG key ID: B0D11345E65C4D48
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
convert-hf-to-gguf-update.py
View file

@ -109,12 +109,12 @@ for model in models:
model_config_path = f"{model_name_or_path}/config.json" model_config_path = f"{model_name_or_path}/config.json"
# check dir path # check dir path
if not os.path.exists(model_name_or_path): # TOCTOU if os.path.exists(model_name_or_path): # Still TOCTOU?
os.makedirs(model_name_or_path)
else:
logger.info(f"Directory {model_name_or_path} already exists - skipping") logger.info(f"Directory {model_name_or_path} already exists - skipping")
continue continue
os.makedirs(model_name_or_path, exist_ok=True)
logger.info(f"Downloading {name} to {model_name_or_path}") logger.info(f"Downloading {name} to {model_name_or_path}")
# model and repo urls are not the same # model and repo urls are not the same