attempt to speed up float clearing.

This commit is contained in:
Julia Longtin 2024-03-23 15:55:00 +00:00
parent a015d8485e
commit 7f5adf3b5c

View file

@ -15,14 +15,39 @@
// For block_q5_K and block_q8_K. only given the second time.
#include "ggml-common.h"
// This SIMD unit can work with 32 float32s at once.
#define GGML_F32_STEP 32
// We can fit 16 of these float32s in a single vector register.
#define GGML_F32_EPR 16
typedef float float32x8_t __attribute__((vector_size (64)));
/* A forward declaration, to keep GCC happy. */
void ggml_vec_dot_q5_K_q8_K(int n, float * restrict s, size_t bs, const void * restrict vx, size_t bx, const void * restrict vy, size_t by, int nrc);
inline static void GGML_F32x8_VEC_ZERO(float32x8_t *target)
{
uint8_t zero[4] __attribute__((aligned(64))) = {0,0,0,0};
uint32_t mask=0x000000FF;
__asm__ __volatile__ (
"vbroadcastf32x4\t%[Z]%{uint8%},\t%%zmm8\n\t" // use an upscaling operator to clear our value.
"kmov\t%[M],\t%%k1\n\t"
"vmovaps\t\t%%zmm8,\t%[RES]%{%%k1%}\n\t"
: [RES] "+m" (*target)
: [Z] "m" (zero)
: [M] "r" (mask)
: "r9", "zmm8", "k1");
}
void ggml_vec_dot_q5_K_q8_K(int n, float * restrict s, size_t bs, const void * restrict vx, size_t bx, const void * restrict vy, size_t by, int nrc) {
/* interpret X and Y as vectors. */
const block_q5_K * restrict x = vx;
const block_q8_K * restrict y = vy;
/* the number of blocks we will process this in. */
const int nb = n / QK_K;
static const uint32_t kmask1 = 0x3f3f3f3f;
@ -32,8 +57,10 @@ void ggml_vec_dot_q5_K_q8_K(int n, float * restrict s, size_t bs, const void * r
uint32_t utmp[4];
int8_t aux8[QK_K];
int16_t aux16[16];
float sums [8];
memset(sums, 0, 8*sizeof(float));
float32x8_t sums __attribute__((aligned(64)));
/* use a vector operation to clear these floats. */
GGML_F32x8_VEC_ZERO(&sums);
float sumf = 0;
for (int i = 0; i < nb; ++i) {
@ -56,10 +83,10 @@ void ggml_vec_dot_q5_K_q8_K(int n, float * restrict s, size_t bs, const void * r
for (int j = 0; j < QK_K/16; ++j) {
const float dl = d * sc[j];
for (int l = 0; l < 16; ++l) aux16[l] = q8[l] * a[l];
for (int l = 0; l < 8; ++l) sums[l] += dl * (aux16[l] + aux16[8+l]);
for (int l = 0; l < 8; ++l) ((float *)sums)[l] += dl * (aux16[l] + aux16[8+l]);
q8 += 16; a += 16;
}
}
for (int l = 0; l < 8; ++l) sumf += sums[l];
for (int l = 0; l < 8; ++l) sumf += ((float *)sums)[l];
*s = sumf;
}