vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

train : remove inaccurate my_llama_hparams::operator== (clang-tidy)

Browse source 
This operator overload is not used anyway - explicitly deleting it seems
to have no effect on compilation.

train-text-from-scratch.cpp:174:16: warning: comparing object representation of type 'my_llama_hparams' which does not have a unique object representation; consider comparing the members of the object manually [bugprone-suspicious-memory-comparison]
        return memcmp(this, &other, sizeof(my_llama_hparams));
               ^
This commit is contained in:
Cebtenzzre 2023-09-05 18:51:58 -04:00
parent f75865610d
commit 87b90f505d
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
examples/train-text-from-scratch/train-text-from-scratch.cpp
View file

@ -169,10 +169,6 @@ struct my_llama_hparams {
float rope_freq_base = 10000.0f; float rope_freq_base = 10000.0f;
float rope_freq_scale = 1.0f; float rope_freq_scale = 1.0f;
bool operator!=(const my_llama_hparams& other) const {
return memcmp(this, &other, sizeof(my_llama_hparams));
}
}; };
struct my_llama_layer { struct my_llama_layer {