first notes

This commit is contained in:
ltoniazzi 2024-06-10 22:48:39 +01:00
parent fd5ea0f897
commit 8802d63c93
2 changed files with 8 additions and 1 deletions

7
NOTES.md Normal file
View file

@ -0,0 +1,7 @@
# TODOs
1. How to debug mat_mul (run tests in cpp?)
2. How to wrap the suggestion from lauren on matmul (need to see how to find the llora info to pick up). Something about lora being loaded in the context? How to pick a specifi LoRA
3. check the PR "It was removed in [#7204](https://github.com/ggerganov/llama.cpp/pull/7204). `convert-lora-to-ggml.py` seems to write loras to gguf witouth the model? Should check the train script and see how they match lora with base layers
4. https://github.com/ggerganov/llama.cpp/discussions/3489
5. check lora example in examples

View file

@ -2782,7 +2782,7 @@ def parse_args() -> argparse.Namespace:
help="model is executed on big endian machine",
)
parser.add_argument(
"model", type=Path,
"--model",dest="model", type=Path, default="models/phi-3-mini/",
help="directory containing model file",
)
parser.add_argument(