From 9abb25278ae821b7725c3cde2796632aeb15beb3 Mon Sep 17 00:00:00 2001 From: HimariO Date: Fri, 13 Dec 2024 18:11:08 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Georgi Gerganov --- ggml/src/ggml.c | 2 +- src/llama.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ggml/src/ggml.c b/ggml/src/ggml.c index df854f902..aa4c952c9 100644 --- a/ggml/src/ggml.c +++ b/ggml/src/ggml.c @@ -3528,7 +3528,7 @@ static struct ggml_tensor * ggml_rope_impl( memcpy(params + 8, &attn_factor, sizeof(float)); memcpy(params + 9, &beta_fast, sizeof(float)); memcpy(params + 10, &beta_slow, sizeof(float)); - memcpy(params + 11, §ions, sizeof(int) * 4); + memcpy(params + 11, §ions, sizeof(int) * 4); ggml_set_op_params(result, params, sizeof(params)); result->op = GGML_OP_ROPE; diff --git a/src/llama.cpp b/src/llama.cpp index 83ed32800..e7b8ee077 100644 --- a/src/llama.cpp +++ b/src/llama.cpp @@ -2555,9 +2555,9 @@ struct llama_hparams { if (this->n_ff_shexp != other.n_ff_shexp) return true; if (this->n_expert_shared != other.n_expert_shared) return true; - if (this->rope_finetuned != other.rope_finetuned) return true; - if (this->n_ctx_orig_yarn != other.n_ctx_orig_yarn) return true; - if (this->rope_sections != other.rope_sections) return true; + if (this->rope_finetuned != other.rope_finetuned) return true; + if (this->n_ctx_orig_yarn != other.n_ctx_orig_yarn) return true; + if (this->rope_sections != other.rope_sections) return true; if (this->ssm_d_conv != other.ssm_d_conv) return true; if (this->ssm_d_inner != other.ssm_d_inner) return true;