vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: add bash script to check if llama-impl.h was included in example folder erronously

Browse source
This commit is contained in:
brian khuu 2025-02-04 07:06:08 +11:00
parent 4033365e00
commit a444c15209
2 changed files with 12 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Makefile
View file

@ -211,7 +211,7 @@ ifdef GGML_VULKAN
BUILD_TARGETS += vulkan-shaders-gen BUILD_TARGETS += vulkan-shaders-gen
endif endif
default: precompile_checks $(BUILD_TARGETS) $(LEGACY_TARGETS_BUILD) default: $(BUILD_TARGETS) $(LEGACY_TARGETS_BUILD)
test: $(TEST_TARGETS) test: $(TEST_TARGETS)
@failures=0; \ @failures=0; \
@ -248,10 +248,6 @@ test: $(TEST_TARGETS)
all: $(BUILD_TARGETS) $(TEST_TARGETS) $(LEGACY_TARGETS_BUILD) all: $(BUILD_TARGETS) $(TEST_TARGETS) $(LEGACY_TARGETS_BUILD)
# Run the forbidden includes check before every build
precompile_checks:
@bash ./scripts/precompile-checks.sh
ifdef RISCV_CROSS_COMPILE ifdef RISCV_CROSS_COMPILE
CC := riscv64-unknown-linux-gnu-gcc CC := riscv64-unknown-linux-gnu-gcc
CXX := riscv64-unknown-linux-gnu-g++ CXX := riscv64-unknown-linux-gnu-g++

22
scripts/precompile-checks.sh
View file

@ -11,23 +11,23 @@ SRC_DIR="./examples"
FORBIDDEN_HEADERS=("llama-impl.h") FORBIDDEN_HEADERS=("llama-impl.h")
echo "🔍 Scanning for forbidden includes in $SRC_DIR..." echo "🔍 Scanning for forbidden includes in $SRC_DIR..."
for HEADER in "${FORBIDDEN_HEADERS[@]}"; do for HEADER in "${FORBIDDEN_HEADERS[@]}"; do
MATCHES=$(grep -rn --include=\*.{c,cpp} "#include \"$HEADER\"" "$SRC_DIR" 2>/dev/null) MATCHES=$(grep -rn --include=\*.{c,cpp} "#include \"$HEADER\"" "$SRC_DIR" 2>/dev/null)
if [[ -n "$MATCHES" ]]; then if [[ -n "$MATCHES" ]]; then
echo "❌ Forbidden include detected: $HEADER" echo "❌ Forbidden include detected: $HEADER"
echo "$MATCHES" | while IFS=: read -r FILE LINE _; do echo "$MATCHES" | while IFS=: read -r FILE LINE _; do
echo "::error file=$FILE,line=$LINE::Forbidden include: $HEADER in $FILE at line $LINE" echo "::error file=$FILE,line=$LINE::Forbidden include: $HEADER in $FILE at line $LINE"
done done
ERROR_FOUND=1 ERROR_FOUND=1
fi fi
done done
## END OF INCLUDES EXCLUDED FROM EXAMPLES FOLDER ## ## END OF INCLUDES EXCLUDED FROM EXAMPLES FOLDER ##
if [[ "$ERROR_FOUND" -eq 1 ]]; then if [[ "$ERROR_FOUND" -eq 1 ]]; then
echo "❌ Forbidden includes found. Please remove!" echo "❌ Forbidden includes found. Please remove!"
exit 1 exit 1
else else
echo "✅ No forbidden includes found." echo "✅ No forbidden includes found."
fi fi