vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test-grad0 : fix test for div

Browse source 
nargs and ndims was swapped, corrupting the stack
This commit is contained in:
xaedes 2023-04-28 20:00:25 +02:00
parent 19f51592b5
commit b9920e5c3e
No known key found for this signature in database
GPG key ID: 30030EDD817EA2B1
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/test-grad0.c
View file

@ -188,8 +188,8 @@ bool check_gradient(
if (error_abs > max_error_abs || error_rel > max_error_rel) {
printf("%s: ndims=%d, i=%d, k=%d, x0=%f, xm=%f, xp=%f, f0=%f, f1=%f, g0=%f, g1=%f, eps=%f, error_abs=%f, error_rel=%f\n",
op_name, ndims, i, k, x0, xm, xp, f0, f1, g0, g1, eps, error_abs, error_rel);
assert(false);
return false;
assert(false);
return false;
}
}
}
@ -361,9 +361,9 @@ int main(int argc, const char ** argv) {
// div
{
const int nargs = 4;
const int nargs = 2;
for (int ndims = 1; ndims <= 2; ++ndims) {
for (int ndims = 1; ndims <= 4; ++ndims) {
for (int i = 0; i < nargs; ++i) {
x[i] = get_random_tensor(ctx0, ndims, ne, 0.5f, 1.0f);
ggml_set_param(ctx0, x[i]);
@ -371,7 +371,7 @@ int main(int argc, const char ** argv) {
struct ggml_tensor * f = ggml_sum(ctx0, ggml_div(ctx0, x[0], x[1]));
check_gradient("div", ctx0, x, f, ndims, nargs, 1e-3f, INFINITY, 1e-2f);
check_gradient("div", ctx0, x, f, ndims, nargs, 1e-3f, 1e-2f, 1e-1f);
}
}