From cb864773ba0efee10cf28b32d40980375c08d997 Mon Sep 17 00:00:00 2001
From: Eric Sommerlade <ersomme@microsoft.com>
Date: Sat, 9 Sep 2023 13:35:50 +0100
Subject: [PATCH] addressed PR comments

---
 CMakeLists.txt | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index dfda28c48..2ecb5839e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -475,13 +475,11 @@ endif()
 if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm" OR ${CMAKE_SYSTEM_PROCESSOR} MATCHES "aarch64" OR "${CMAKE_GENERATOR_PLATFORM_LWR}" MATCHES "arm64")
     message(STATUS "ARM detected")
     if (MSVC)
-        # TODO: arm msvc?
-        # x86 add_compile_options(/arch:AVX2)
         add_compile_definitions(__ARM_NEON)
         add_compile_definitions(__ARM_FEATURE_FMA)
         add_compile_definitions(__ARM_FEATURE_DOTPROD)
-        #add_compile_definitions(__ARM_FEATURE_FP16_VECTOR_ARITHMETIC)
-        add_compile_definitions(__aarch64__) # MSVC _M_ARM64
+        # add_compile_definitions(__ARM_FEATURE_FP16_VECTOR_ARITHMETIC) # MSVC doesn't support vdupq_n_f16, vld1q_f16, vst1q_f16
+        add_compile_definitions(__aarch64__) # MSVC defines _M_ARM64 instead
     else()
         if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "armv6")
             # Raspberry Pi 1, Zero