Address review comments

This commit is contained in:
Michael Klimenko 2024-01-27 00:32:29 +01:00
parent d745a36b30
commit cc563aaca0
2 changed files with 2 additions and 1 deletions

View file

@ -813,6 +813,7 @@ static void hellaswag_score(llama_context * ctx, const gpt_params & params) {
llama_batch batch = llama_batch_init(n_ctx, 0, max_seq);
std::vector<float> tok_logits(n_vocab);
std::vector<float> batch_logits(n_vocab*n_ctx);
std::vector<std::pair<size_t, llama_token>> eval_pairs;

View file

@ -11,7 +11,7 @@ char * get_model_or_exit(int argc, char *argv[]) {
} else {
model_path = getenv("LLAMACPP_TEST_MODELFILE");
if (!model_path || model_path[0] == '\0') {
if (!model_path || strlen(model_path) == 0) {
fprintf(stderr, "\033[33mWARNING: No model file provided. Skipping this test. Set LLAMACPP_TEST_MODELFILE=<gguf_model_path> to silence this warning and run this test.\n\033[0m");
exit(EXIT_SUCCESS);
}