From ce89cd557384df107f8a6e300fc901f1b1e8054b Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Wed, 22 May 2024 10:10:42 +0300 Subject: [PATCH] ggml : drop mode & 1 == 1 support for ggml_rope ggml-ci --- ggml.c | 2 ++ ggml.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ggml.c b/ggml.c index 37b16b7a9..11d71c07a 100644 --- a/ggml.c +++ b/ggml.c @@ -6245,6 +6245,8 @@ static struct ggml_tensor * ggml_rope_impl( float xpos_base, bool xpos_down, bool inplace) { + GGML_ASSERT((mode & 1) == 0 && "mode & 1 == 1 is no longer supported"); + GGML_ASSERT(ggml_is_vector(b)); GGML_ASSERT(b->type == GGML_TYPE_I32); GGML_ASSERT(a->ne[2] == b->ne[0]); diff --git a/ggml.h b/ggml.h index 35ac9110c..08835042c 100644 --- a/ggml.h +++ b/ggml.h @@ -1460,7 +1460,7 @@ extern "C" { struct ggml_tensor * b); // rotary position embedding - // if mode & 1 == 1, skip n_past elements (DEPRECATED) + // if mode & 1 == 1, skip n_past elements (NOT SUPPORTED) // if mode & 2 == 1, GPT-NeoX style // if mode & 4 == 1, ChatGLM style //