vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

minor : cleanup

Browse source
This commit is contained in:
Georgi Gerganov 2024-05-16 13:53:22 +03:00
parent 4f787ead14
commit d93b5cad0a
No known key found for this signature in database
GPG key ID: 449E073F9DC10735
2 changed files with 3 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ggml-cuda/rope.cu
View file

@ -291,7 +291,7 @@ void ggml_cuda_op_rope(ggml_backend_cuda_context & ctx, ggml_tensor * dst) {
freq_factors = (const float *) src2->data; freq_factors = (const float *) src2->data;
} }
} else { } else {
GGML_ASSERT(src2 == nullptr && "TODO: freq_factors not implemented for mode 1"); GGML_ASSERT(src2 == nullptr && "TODO: freq_factors not implemented for !is_neox");
} }
rope_corr_dims corr_dims; rope_corr_dims corr_dims;

14
ggml-metal.m
View file

@ -2263,18 +2263,8 @@ static enum ggml_status ggml_metal_graph_compute(
GGML_ASSERT(!is_glm && "GLM RoPE not implemented in Metal"); GGML_ASSERT(!is_glm && "GLM RoPE not implemented in Metal");
if (is_neox) { if (!is_neox) {
// TODO: move these asserts to ggml.c GGML_ASSERT(id_src2 == nil && "TODO: freq_factors not implemented for !is_neox");
GGML_ASSERT(src1->type == GGML_TYPE_I32);
GGML_ASSERT(src1->ne[0] == ne2);
if (id_src2 != nil) {
// TODO: move these asserts to ggml.c
GGML_ASSERT(src2->type == GGML_TYPE_F32);
GGML_ASSERT(src2->ne[0] >= n_dims / 2);
}
} else {
GGML_ASSERT(id_src2 == nil && "TODO: freq_factors not implemented for mode 1");
} }
id<MTLComputePipelineState> pipeline = nil; id<MTLComputePipelineState> pipeline = nil;