From e159e7751c5e358da439745141584d57f2056e40 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Sun, 12 Jan 2025 14:35:29 +0200 Subject: [PATCH] cmake : disable -Wshadow for GCC ggml-ci --- cmake/common.cmake | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cmake/common.cmake b/cmake/common.cmake index c64ddbc3d..bbc9c412e 100644 --- a/cmake/common.cmake +++ b/cmake/common.cmake @@ -13,7 +13,12 @@ function(llama_add_compile_flags) list(APPEND C_FLAGS -Wshadow -Wstrict-prototypes -Wpointer-arith -Wmissing-prototypes -Werror=implicit-int -Werror=implicit-function-declaration) - list(APPEND CXX_FLAGS -Wshadow -Wmissing-declarations -Wmissing-noreturn) + list(APPEND CXX_FLAGS -Wmissing-declarations -Wmissing-noreturn) + + # GCC -Wshadow is way too agressive + if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") + list(APPEND CXX_FLAGS -Wshadow) + endif() list(APPEND WARNING_FLAGS -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function)