From e96d26340779119edd7b97e5cc8d0e57c8c68081 Mon Sep 17 00:00:00 2001 From: Brian Date: Wed, 31 Jul 2024 00:29:33 +1000 Subject: [PATCH] Apply suggestions from code review I was wondering if there was a specific reason for `if val` but good to hear we can safely use `len(val == 0` Co-authored-by: compilade --- gguf-py/gguf/gguf_writer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gguf-py/gguf/gguf_writer.py b/gguf-py/gguf/gguf_writer.py index d9f04aeb7..2e0b335ee 100644 --- a/gguf-py/gguf/gguf_writer.py +++ b/gguf-py/gguf/gguf_writer.py @@ -312,7 +312,7 @@ class GGUFWriter: self.add_key_value(key, val, GGUFValueType.STRING) def add_array(self, key: str, val: Sequence[Any]) -> None: - if not val: + if len(val) == 0: return self.add_key_value(key, val, GGUFValueType.ARRAY) @@ -852,7 +852,7 @@ class GGUFWriter: if not isinstance(val, Sequence): raise ValueError("Invalid GGUF metadata array, expecting sequence") - if not val: + if len(val) == 0: raise ValueError("Invalid GGUF metadata array. Empty array") if isinstance(val, bytes):