vbatts/llama.cpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

metal : put warning in kernel_norm to not combine the loops

Browse source
This commit is contained in:
Georgi Gerganov 2023-09-07 14:59:48 +03:00
parent 5e1c4089d8
commit ed92c3d4b2
No known key found for this signature in database
GPG key ID: 449E073F9DC10735
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ggml-metal.metal
View file

@ -235,6 +235,12 @@ kernel void kernel_norm(
// VARIANCE // VARIANCE
// parallel sum // parallel sum
//
// WARNING: combining this loop with the one above will give you wrong results for nth == 256
// I have no idea why, so for now I am keeping them separate. But this behavior is very concerning.
// Tested with:
// ./perplexity -m ./falcon-7b/ggml-model-q4_0.gguf -f wiki.test.raw -ngl 1 -t 4
//
sum[tpitg] = 0.0f; sum[tpitg] = 0.0f;
for (int i00 = tpitg; i00 < ne00; i00 += ntg) { for (int i00 = tpitg; i00 < ne00; i00 += ntg) {
sum[tpitg] += y[i00] * y[i00]; sum[tpitg] += y[i00] * y[i00];