Commit graph

762 commits

Author SHA1 Message Date
Eugen Rochko
c3965e28b3
Fix returning results when searching for URL with non-zero offset ()
Fix 
2020-04-02 03:39:37 +02:00
Takeshi Umeda
11169367e4
Fix incorrect deletion of local accounts imported by overwriting () 2020-03-30 20:32:34 +02:00
ThibG
f08f880f58
Fix media not being marked sensitive when client sets a CW but no text ()
Mastodon enforces the “sensitive” flag on media attachments whenever a toot
is posted with a Content Warning. However, it does so *after* potentially
converting the Content Warning to toot text (when there is no toot text),
which leads to inconsistent and surprising behavior for API clients.
This commit fixes this inconsistency.
2020-03-25 22:40:58 +01:00
ThibG
cb12a2cdd3
Fix some timeouts when searching URLs by limiting some database queries ()
Only look up private toots from database if the request failed because of 401,
403 or 404 errors, as those may indicate a private toot, rather than something
that isn't a toot or cannot be processed.
2020-03-12 23:06:43 +01:00
ThibG
b154428e14
Add federation support for the "hide network" preference ()
* Change ActivityPub follower/following collections to not link first page

* Add support for hiding followers and following of remote users

* Switch to using a single `hide_collections` column

* Address code style remarks
2020-03-09 00:10:29 +01:00
Eugen Rochko
9660aa4543
Change local media attachments to perform heavy processing asynchronously ()
Fix 
2020-03-08 23:56:18 +01:00
ThibG
5284e29e2f
Fix public posts from silenced accounts not being changed to unlisted visibility () 2020-03-08 16:11:49 +01:00
ThibG
6185bff4b3
Fix error when searching for URLs that contain the mention syntax ()
Fixes 
2020-03-08 15:42:20 +01:00
Eugen Rochko
339ce1c4e9
Add specific rate limits for posting and following () 2020-03-08 15:17:39 +01:00
ThibG
cf4fe6caef
Fix misleading error when attempting to re-send a pending follow request ()
Fixes 
2020-02-24 21:19:19 +01:00
ThibG
d91946ae13
Fix backups failing when files are missing from media attachments ()
Fixes 
2020-02-24 21:18:26 +01:00
ThibG
3704402dcc
Fix duplicate accounts being created when fetching an account for its key only ()
Fixes 

When a user's canonical acct domain is different from its id's domain
(WEB_DOMAIN ≠ LOCAL_DOMAIN), two webfinger queries are required to find the
canonical domain from the URI. However, we skip webfinger queries when
updating only the key of a remote user, which led to the creation of a
duplicate account, using the URI's domain instead of the canonical acct: one.
2020-02-24 21:15:53 +01:00
ThibG
983ab40086
Fix previously OStatus-based accounts not being detected as ActivityPub () 2020-02-22 01:26:41 +01:00
ThibG
d386d89179 Fix invalid votes from the API being accepted ()
* Fix invalid votes from the API being accepted

Fixes 

- Ensure `choice` is an integer instead of silently converting to 0
- Ensure `choice` corresponds to an actual choice of the poll

* Please CodeClimate
2020-01-12 14:17:03 +01:00
Daigo 3 Dango
206dfd7dad Clarify keyword arguments with ** ()
This change is to suppress the warning below on on ruby-2.7.0:

- warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
2020-01-11 05:57:05 +09:00
ThibG
c306978190 Use quality values in Accept field to explicitly prefer JSON over HTML () 2020-01-10 00:10:29 +01:00
ThibG
e4d75f238b Fix URL search not returning private toots user has access to () 2020-01-03 05:01:45 +01:00
Eugen Rochko
f86ee4b59f
Fix IDN mentions not being processed, IDN domains not being rendered ()
This changes the REST API to return unicode domains in the `acct`
attribute instead of punycode, and to render unicode instead of
punycode on public HTML pages as well.

Fix , fix 
2019-12-30 19:20:43 +01:00
chr v1.x
7e074610a6 Fix backups stopping due to read timeouts ()
* Make BackupService resilient to read timeouts

If an attachment read times out, assume that the resources is
inaccessible and continue the backup without it. This fixes .

* Both errors on one line
2019-12-30 03:17:54 +01:00
ThibG
b364175e1b Fix link crawler not specifying accepted content-type ()
The link crawler expects HTML documents, so set the `Accept`
header accordingly.

Fixes 
2019-12-18 16:56:06 +01:00
Takeshi Umeda
68070e82cc Add signature to exported status () 2019-12-18 16:55:21 +01:00
Takeshi Umeda
a391eaf4d8 Fix an error when ActivityPub::FetchRemoteStatusService url is called with nil () 2019-12-18 16:54:03 +01:00
ThibG
2ee5a9d9c3 Clean up OStatus-related codepaths ()
* Remove “protocol” argument and return value, as only ActivityPub is supported

* Remove FetchRemoteAccountService, only use ActivityPub::FetchRemoteAccountService

* Fix tests
2019-12-17 13:32:57 +01:00
Alice Gaudon
668f698077 Admin setting to disable default follows () 2019-12-16 23:55:50 +01:00
trwnh
1653ae91ce Fix account search with no query ()
* Fix account search with no query

Modeled after . Fix 

* fix codeclimate
2019-12-06 19:44:23 +01:00
Eugen Rochko
bbf926b1c0
Fix error when using search API with no query ()
Fix 
2019-12-04 04:34:08 +01:00
ThibG
911cc14481 Add follow_request notification type ()
* Add follow_request notification type

The notification type already existed in the backend but was never pushed
to the front-end. This also means translation strings were also available
for the backend, from the notification mailer.

Unlike other notification types, these are off by default, to match what
I remember of Gargron's view on the topic: that follow requests should not
clutter notifications and should instead be reviewed at the user's own
leisure in the dedicated column.

Since follow requests have their own column, I've deemed it unnecessary to
add a specific tab for them in the notification quick filter.

* Show follow request link in single-column if there are pending requests, even if account isn't locked

* Push follow requests from notifications to the follow_requests list

* Offer to accept or reject follow request from the notification

* Redesign follow request notification
2019-12-01 17:25:29 +01:00
ThibG
00c219aa45 Fix empty poll options not being filtered on remote poll update ()
If a poll contains empty options (which is apparently possible on Pleroma),
it is created without them. However, the poll update code doesn't filter
empty options, and thus:
1. Clear known votes, as it assumes the set of options has changed
2. Errors out because it tries adding empty options, which fails validation

This commit fixes that by filtering them out the same way they are filtered
out at poll creation time.
2019-11-26 22:46:31 +01:00
Eugen Rochko
a60b602ade
Fix OEmbed discovery not handling different URL variants in query ()
Fix 
2019-11-21 19:03:07 +01:00
ThibG
c656cc2191 Fix FetchLinkCardServices crashing on a tags without a target ()
* Add test for links without targets

* Fix FetchLinkCardServices crashing on a tags without a target
2019-11-21 16:04:52 +01:00
ThibG
c4d45765e3 Change domain block behavior to update user records before deleting data ()
When suspending or silencing a domain, one probably wants the silence or
suspend parts to take effect as soon as possible. Deleting media files can
take a while (possibly days), so perform silencing as soon as possible, and
clean up media afterwards.
2019-11-21 11:36:15 +01:00
Eugen Rochko
d14e74eff5
Add cache for OEmbed endpoints to avoid extra HTTP requests ()
* add youtube oembed endpoint

* add check for oembed endpoint

* change unless for a more readable if

* clear blank lines

* endpoint via https

* Fix string literal in condition

* use cache for endpoints

* use cache for endpoints

* clean up and adding check

* clean up and remove redundant return

* add html check

* add false to return

* use double quotes

* use double quotes

* Clean up
2019-11-17 18:40:33 +01:00
ThibG
dfea7368c9 Add bookmarks ()
* Add backend support for bookmarks

Bookmarks behave like favourites, except they aren't shared with other
users and do not have an associated counter.

* Add spec for bookmark endpoints

* Add front-end support for bookmarks

* Introduce OAuth scopes for bookmarks

* Add bookmarks to archive takeout

* Fix migration

* Coding style fixes

* Fix rebase issue

* Update bookmarked_statuses to latest UI changes

* Update bookmark actions to properly reflect status changes in state

* Add bookmarks item to single-column layout

* Make active bookmarks red
2019-11-13 23:02:10 +01:00
ThibG
0d5f3ae331 Fix already-known remote private toots not being searchable by URL ()
* Fix already-known remote private toots not being searchable by URL

Whenever an URL search fails, and an account is provided, try getting a
private status matching that URL from database.

* Fix searching by `id` field instead of `uri`
2019-11-11 00:04:48 +02:00
ThibG
66c1fe0495 Fix various issues with account migration ()
* Fix being able to follow oneself by moving to an account that was following the old one

* Add specs

* Add spec to catch MoveWorker issue with local followers following both accounts

* Fix move worker breaking when a local account follows both source and target accounts

* Fix migration from remote to local account not sending Undo Follow

* Fix show_reblogs not being preserved for moved account's followers
2019-11-07 09:05:07 +02:00
ThibG
65e13cfacf Add abilityto add oneself to lists ()
* Add ability to add oneself to lists

* Change search results to include oneself when searching through followers

* Mark follow relation as optional in ListAccount
2019-11-04 13:02:01 +01:00
nightpool
9762fe382c microformat mentions can have an implicit property ()
See the first example here: http://microformats.org/wiki/microformats2#hyperlinked_person
2019-10-24 22:46:15 +02:00
Eugen Rochko
8386d9ec10
Fix hashtag timeline REST API accepting too many hashtags () 2019-10-07 03:56:21 +02:00
Eugen Rochko
eb83d6256e
Add reason param to POST /api/v1/accounts REST API ()
For approval-required registrations mode
2019-10-03 17:50:59 +02:00
ThibG
3a4d994c40 Fix BootstrapTimelineService crashing when bootstrapped accounts are invalid ()
* Add test to handle suspended and missing users in BootstrapTimelineService

* Fix BootstrapTimelineService crashing when bootstrapped accounts are invalid
2019-10-01 15:10:00 +02:00
Eugen Rochko
9ba40a6bfd
Remove HEAD request from fetching link previews ()
It is not really necessary and we need to reduce requests
2019-10-01 04:54:10 +02:00
abcang
9ef5532a7e Fix follow requests N+1 () 2019-09-30 17:02:03 +02:00
ThibG
3babf8464b Add voters count support ()
* Add voters count to polls

* Add ActivityPub serialization and parsing of voters count

* Add support for voters count in WebUI

* Move incrementation of voters count out of redis lock

* Reword “voters” to “people”
2019-09-29 22:58:01 +02:00
Eugen Rochko
368a87755b
Fix account migration not affecting followers on origin server () 2019-09-29 16:23:13 +02:00
Eugen Rochko
3ec80c7aec
Fix preview card image not being re-fetched even if link is re-posted ()
Fix 
2019-09-28 01:33:16 +02:00
Eugen Rochko
ab33c4df94
Add exclude_unreviewed param to GET /api/v2/search REST API ()
Make it so normal search returns even unreviewed matches, but
autosuggestions do not.

Fix 
2019-09-28 01:02:21 +02:00
ThibG
18b451c0e6 Change silences to always require approval on follow ()
* Change silenced accounts to require approval on follow

* Also require approval for follows by people explicitly muted by target accounts

* Do not auto-accept silenced or muted accounts when switching from locked to unlocked

* Add `follow_requests_count` to verify_credentials

* Show “Follow requests” menu item if needed even if account is locked

* Add tests

* Correctly reflect that follow requests weren't auto-accepted when local account is silenced

* Accept follow requests from user-muted accounts to avoid leaking mutes
2019-09-27 21:13:51 +02:00
Eugen Rochko
2f90a38f44
Fix unreviewed hashtag not being found by exact case-insensitive match () 2019-09-27 19:40:26 +02:00
Jeong Arm
00d7bdcc2a Fix search error when ElasticSearch is enabled but not available ()
* Fallback to Database search when ES not available

* Prevent double work if ES gives 0 result

* Apply suggestion from code review
2019-09-26 18:06:08 +02:00
Eugen Rochko
4f6af87906
Change spam check to apply to local accounts and add a threshold ()
Instead of detecting spam on first duplicate message, add a
threshold of 5 such messages to reduce false positives
2019-09-18 12:53:13 +02:00