406adfca27
* Fix 2FA/sign-in token sessions being valid after password change (#14802) If someone tries logging in to an account and is prompted for a 2FA code or sign-in token, even if the account's password or e-mail is updated in the meantime, the session will show the prompt and allow the login process to complete with a valid 2FA code or sign-in token * Fix Move handler not being triggered when failing to fetch target (#15107) When failing to fetch the target account, the ProcessingWorker fails as expected, but since it hasn't cleared the `move_in_progress` flag, the next attempt at processing skips the `Move` activity altogether. This commit changes it to clear the flag when encountering any unexpected error on fetching the target account. This is likely to occur because, of, e.g., a timeout, when many instances query the same actor at the same time. * Fix slow distinct queries where grouped queries are faster (#15287) About 2x speed-up on inboxes query * Fix possible inconsistencies in tag search (#14906) Do not downcase the queried tag before passing it to postgres when searching: - tags are not downcased on creation - `arel_table[:name].lower.matches(pattern)` generates an ILIKE anyway - if Postgres and Rails happen to use different case-folding rules, downcasing before query but not before insertion may mean that some tags with some casings are not searchable * Fix updating account counters when account_stat is not yet created (#15108) * Fix account processing failing because of large collections (#15027) Fixes #15025 * Fix downloading remote media files when server returns empty filename (#14867) Fixes #14817 * Fix webfinger redirect handling in ResolveAccountService (#15187) * Fix webfinger redirect handling in ResolveAccountService ResolveAccountService#process_webfinger! handled a one-step webfinger redirection, but only accepting the result if it matched the exact URI passed as input, defeating the point of a redirection check. Instead, use the same logic as in `ActivityPub::FetchRemoteAccountService`, updating the resulting `acct:` URI with the result of the first webfinger query. * Add tests * Remove dependency on unused and unmaintained http_parser.rb gem (#14574) It seems that years ago, the “http” gem dependend on the “http_parser.rb” gem (it now depends on the “http-parser” gem), and, still years ago, we pulled it from git in order to benefit from a bugfix that wasn't released yet (#7467). * Add tootctl maintenance fix-duplicates (#14860, #15201, #15264, #15349, #15359) * Fix old migration script not being able to run if it fails midway (#15361) * Fix old migration script not being able to run if it fails midway Improve the robustness of a migration script likely to fail because of database corruption so it can run again once database corruptions are fixed. * Display a specific error message in case of index corruption Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>
124 lines
3.6 KiB
Ruby
124 lines
3.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Api::BaseController < ApplicationController
|
|
DEFAULT_STATUSES_LIMIT = 20
|
|
DEFAULT_ACCOUNTS_LIMIT = 40
|
|
|
|
include RateLimitHeaders
|
|
|
|
skip_before_action :store_current_location
|
|
skip_before_action :require_functional!, unless: :whitelist_mode?
|
|
|
|
before_action :require_authenticated_user!, if: :disallow_unauthenticated_api_access?
|
|
before_action :set_cache_headers
|
|
|
|
protect_from_forgery with: :null_session
|
|
|
|
skip_around_action :set_locale
|
|
|
|
rescue_from ActiveRecord::RecordInvalid, Mastodon::ValidationError do |e|
|
|
render json: { error: e.to_s }, status: 422
|
|
end
|
|
|
|
rescue_from ActiveRecord::RecordNotUnique do
|
|
render json: { error: 'Duplicate record' }, status: 422
|
|
end
|
|
|
|
rescue_from ActiveRecord::RecordNotFound do
|
|
render json: { error: 'Record not found' }, status: 404
|
|
end
|
|
|
|
rescue_from HTTP::Error, Mastodon::UnexpectedResponseError do
|
|
render json: { error: 'Remote data could not be fetched' }, status: 503
|
|
end
|
|
|
|
rescue_from OpenSSL::SSL::SSLError do
|
|
render json: { error: 'Remote SSL certificate could not be verified' }, status: 503
|
|
end
|
|
|
|
rescue_from Mastodon::NotPermittedError do
|
|
render json: { error: 'This action is not allowed' }, status: 403
|
|
end
|
|
|
|
rescue_from Mastodon::RaceConditionError do
|
|
render json: { error: 'There was a temporary problem serving your request, please try again' }, status: 503
|
|
end
|
|
|
|
rescue_from Mastodon::RateLimitExceededError do
|
|
render json: { error: I18n.t('errors.429') }, status: 429
|
|
end
|
|
|
|
rescue_from ActionController::ParameterMissing do |e|
|
|
render json: { error: e.to_s }, status: 400
|
|
end
|
|
|
|
def doorkeeper_unauthorized_render_options(error: nil)
|
|
{ json: { error: (error.try(:description) || 'Not authorized') } }
|
|
end
|
|
|
|
def doorkeeper_forbidden_render_options(*)
|
|
{ json: { error: 'This action is outside the authorized scopes' } }
|
|
end
|
|
|
|
protected
|
|
|
|
def set_pagination_headers(next_path = nil, prev_path = nil)
|
|
links = []
|
|
links << [next_path, [%w(rel next)]] if next_path
|
|
links << [prev_path, [%w(rel prev)]] if prev_path
|
|
response.headers['Link'] = LinkHeader.new(links) unless links.empty?
|
|
end
|
|
|
|
def limit_param(default_limit)
|
|
return default_limit unless params[:limit]
|
|
[params[:limit].to_i.abs, default_limit * 2].min
|
|
end
|
|
|
|
def params_slice(*keys)
|
|
params.slice(*keys).permit(*keys)
|
|
end
|
|
|
|
def current_resource_owner
|
|
@current_user ||= User.find(doorkeeper_token.resource_owner_id) if doorkeeper_token
|
|
end
|
|
|
|
def current_user
|
|
current_resource_owner || super
|
|
rescue ActiveRecord::RecordNotFound
|
|
nil
|
|
end
|
|
|
|
def require_authenticated_user!
|
|
render json: { error: 'This method requires an authenticated user' }, status: 401 unless current_user
|
|
end
|
|
|
|
def require_user!
|
|
if !current_user
|
|
render json: { error: 'This method requires an authenticated user' }, status: 422
|
|
elsif current_user.disabled?
|
|
render json: { error: 'Your login is currently disabled' }, status: 403
|
|
elsif !current_user.confirmed?
|
|
render json: { error: 'Your login is missing a confirmed e-mail address' }, status: 403
|
|
elsif !current_user.approved?
|
|
render json: { error: 'Your login is currently pending approval' }, status: 403
|
|
else
|
|
update_user_sign_in
|
|
end
|
|
end
|
|
|
|
def render_empty
|
|
render json: {}, status: 200
|
|
end
|
|
|
|
def authorize_if_got_token!(*scopes)
|
|
doorkeeper_authorize!(*scopes) if doorkeeper_token
|
|
end
|
|
|
|
def set_cache_headers
|
|
response.headers['Cache-Control'] = 'no-cache, no-store, max-age=0, must-revalidate'
|
|
end
|
|
|
|
def disallow_unauthenticated_api_access?
|
|
authorized_fetch_mode?
|
|
end
|
|
end
|