Add test cases for remote actor deletion

This commit is contained in:
Thomas Sileo 2022-08-18 08:32:30 +02:00
parent 228de1b83a
commit 8e57bb9245
3 changed files with 190 additions and 26 deletions

View file

@ -12,24 +12,15 @@ from app import activitypub as ap
from app import models
from app.actor import LOCAL_ACTOR
from app.ap_object import RemoteObject
from app.database import AsyncSession
from app.incoming_activities import fetch_next_incoming_activity
from app.incoming_activities import process_next_incoming_activity
from tests import factories
from tests.utils import mock_httpsig_checker
from tests.utils import run_async
from tests.utils import run_process_next_incoming_activity
from tests.utils import setup_inbox_delete
from tests.utils import setup_remote_actor
from tests.utils import setup_remote_actor_as_follower
from tests.utils import setup_remote_actor_as_following
async def _process_next_incoming_activity(db_session: AsyncSession) -> None:
next_activity = await fetch_next_incoming_activity(db_session)
assert next_activity
await process_next_incoming_activity(db_session, next_activity)
def test_inbox_requires_httpsig(
client: TestClient,
):
@ -70,10 +61,10 @@ def test_inbox_incoming_follow_request(
json=follow_activity.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# And the actor was saved in DB
saved_actor = db.execute(select(models.Actor)).scalar_one()
@ -127,11 +118,11 @@ def test_inbox_incoming_follow_request__manually_approves_followers(
json=follow_activity.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
with mock.patch("app.boxes.MANUALLY_APPROVES_FOLLOWERS", True):
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# And the actor was saved in DB
saved_actor = db.execute(select(models.Actor)).scalar_one()
@ -183,10 +174,10 @@ def test_inbox_accept_follow_request(
json=accept_activity.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# And the Accept activity was saved in the inbox
inbox_activity = db.execute(select(models.InboxObject)).scalar_one()
@ -229,11 +220,11 @@ def test_inbox__create_from_follower(
json=ro.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
# And when processing the incoming activity
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# Then the Create activity was saved
create_activity_from_inbox: models.InboxObject | None = db.execute(
@ -283,11 +274,11 @@ def test_inbox__create_already_deleted_object(
json=ro.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
# And when processing the incoming activity
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# Then the Create activity was saved
create_activity_from_inbox: models.InboxObject | None = db.execute(
@ -339,11 +330,11 @@ def test_inbox__actor_is_blocked(
json=ro.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
# And when processing the incoming activity from a blocked actor
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# Then the Create activity was discarded
assert (
@ -389,10 +380,10 @@ def test_inbox__move_activity(
json=move_activity.ap_object,
)
# Then the server returns a 204
# Then the server returns a 202
assert response.status_code == 202
run_async(_process_next_incoming_activity)
run_process_next_incoming_activity()
# And the Move activity was saved in the inbox
inbox_activity = db.execute(select(models.InboxObject)).scalar_one()