vbatts/microservices-demo
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

paymentservice: money proto migration

Browse source 
the logs will reflect full nanos representation, I'm not sure how to
divide this by 10000000 and left pad a zero (%02d).

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
This commit is contained in:
Ahmet Alp Balkan 2018-06-27 12:42:00 -07:00
parent c2b08f0793
commit 129eb9be66
2 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/paymentservice/charge.js
View file

@ -58,7 +58,7 @@ module.exports = function charge(request) {
throw new ExpiredCreditCard(cardNumber.replace('-', ''), month, year);
console.log(`Transaction processed: ${cardType} ending ${cardNumber.substr(-4)} \
Amount: ${amount.currency_code}${amount.amount.decimal}.${amount.amount.fractional}`)
Amount: ${amount.currency_code}${amount.units}.${amount.nanos}`)
return { transaction_id: uuid() }
}

26
src/paymentservice/proto/demo.proto
View file

@ -63,7 +63,7 @@ message Product {
string name = 2;
string description = 3;
string picture = 4;
MoneyAmount price_usd = 5;
Money price_usd = 5;
}
message ListProductsResponse {
@ -95,7 +95,7 @@ message GetQuoteRequest {
}
message GetQuoteResponse {
MoneyAmount cost_usd = 1;
Money cost_usd = 1;
}
message ShipOrderRequest {
@ -122,18 +122,22 @@ service CurrencyService {
rpc Convert(CurrencyConversionRequest) returns (Money) {}
}
// Describes a money amount without currency. For example, decimal=2 and
// fractional=500 (or fractional=5) makes up 2.5 units.
message MoneyAmount {
uint32 decimal = 1;
uint32 fractional = 2;
}
// Represents an amount of money with its currency type.
message Money {
// The 3-letter currency code defined in ISO 4217.
string currency_code = 1;
MoneyAmount amount = 2;
// The whole units of the amount.
// For example if `currencyCode` is `"USD"`, then 1 unit is one US dollar.
int64 units = 2;
// Number of nano (10^-9) units of the amount.
// The value must be between -999,999,999 and +999,999,999 inclusive.
// If `units` is positive, `nanos` must be positive or zero.
// If `units` is zero, `nanos` can be positive, zero, or negative.
// If `units` is negative, `nanos` must be negative or zero.
// For example $-1.75 is represented as `units`=-1 and `nanos`=-750,000,000.
int32 nanos = 3;
}
message GetSupportedCurrenciesResponse {