From 1372aad8138ec07e83016c6668fb345c56af7bd1 Mon Sep 17 00:00:00 2001 From: Ahmet Alp Balkan Date: Thu, 21 Jun 2018 10:22:28 -0700 Subject: [PATCH] recommendationservice: require PRODUCT_CATALOG_SERVICE_ADDR Signed-off-by: Ahmet Alp Balkan --- src/recommendationservice/Dockerfile | 6 ++---- src/recommendationservice/recommendation_server.py | 4 +++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/recommendationservice/Dockerfile b/src/recommendationservice/Dockerfile index b5c34e0..0491e6f 100644 --- a/src/recommendationservice/Dockerfile +++ b/src/recommendationservice/Dockerfile @@ -8,9 +8,7 @@ ADD ./*.py /home/ WORKDIR /home # set listen port -ENV PORT="8080" - -#set product catalog address -ENV PRODUCT_CATALOG_SERVICE_ADDR="localhost:8081" +ENV PORT "8080" +EXPOSE 8080 ENTRYPOINT python /home/recommendation_server.py diff --git a/src/recommendationservice/recommendation_server.py b/src/recommendationservice/recommendation_server.py index 517bad9..1ea14f5 100644 --- a/src/recommendationservice/recommendation_server.py +++ b/src/recommendationservice/recommendation_server.py @@ -30,7 +30,9 @@ if __name__ == "__main__": # get port from $PORT envar port = os.environ.get('PORT', "8080") # get product catalog service address from $PRODUCT_CATALOG_SERVICE_ADDR envar - catalog_addr = os.environ.get('PRODUCT_CATALOG_SERVICE_ADDR', "localhost:8081") + catalog_addr = os.environ.get('PRODUCT_CATALOG_SERVICE_ADDR', '') + if catalog_addr == "": + raise Exception('PRODUCT_CATALOG_SERVICE_ADDR environment not set') print("product catalog address: " + catalog_addr) print("listening on port: " + port)