vbatts/microservices-demo
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

[cartservice] Increases health check timeout (#240)

Browse source 
* Increases cartservice health check rpc timeout

* remove stopwatch from health check

* cleanup

* Cleanup
This commit is contained in:
Megan O'Keefe 2019-08-19 14:28:03 -04:00 committed by GitHub
parent 13b73067c4
commit 156dfcec8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
release/kubernetes-manifests.yaml
View file

@ -411,12 +411,12 @@ spec:
readinessProbe: readinessProbe:
initialDelaySeconds: 15 initialDelaySeconds: 15
exec: exec:
command: ["/bin/grpc_health_probe", "-addr=:7070"] command: ["/bin/grpc_health_probe", "-addr=:7070", "-rpc-timeout=5s"]
livenessProbe: livenessProbe:
initialDelaySeconds: 15 initialDelaySeconds: 15
periodSeconds: 10 periodSeconds: 10
exec: exec:
command: ["/bin/grpc_health_probe", "-addr=:7070"] command: ["/bin/grpc_health_probe", "-addr=:7070", "-rpc-timeout=5s"]
--- ---
apiVersion: v1 apiVersion: v1
kind: Service kind: Service

1
src/cartservice/HealthImpl.cs
View file

@ -15,7 +15,6 @@ namespace cartservice {
public override Task<HealthCheckResponse> Check(HealthCheckRequest request, ServerCallContext context){ public override Task<HealthCheckResponse> Check(HealthCheckRequest request, ServerCallContext context){
Console.WriteLine ("Checking CartService Health"); Console.WriteLine ("Checking CartService Health");
return Task.FromResult(new HealthCheckResponse { return Task.FromResult(new HealthCheckResponse {
Status = dependency.Ping() ? HealthCheckResponse.Types.ServingStatus.Serving : HealthCheckResponse.Types.ServingStatus.NotServing Status = dependency.Ping() ? HealthCheckResponse.Types.ServingStatus.Serving : HealthCheckResponse.Types.ServingStatus.NotServing
}); });

2
src/cartservice/cartservice.csproj
View file

@ -14,7 +14,7 @@
<PackageReference Include="grpc.tools" Version="1.12.0" /> <PackageReference Include="grpc.tools" Version="1.12.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" /> <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.1" /> <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.1" />
<PackageReference Include="StackExchange.Redis" Version="1.2.6" /> <PackageReference Include="StackExchange.Redis" Version="2.0.601" />
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>

1
src/cartservice/cartstore/RedisCartStore.cs
View file

@ -202,7 +202,6 @@ namespace cartservice.cartstore
{ {
try try
{ {
var redis = ConnectionMultiplexer.Connect(redisConnectionOptions);
var cache = redis.GetDatabase(); var cache = redis.GetDatabase();
var res = cache.Ping(); var res = cache.Ping();
return res != TimeSpan.Zero; return res != TimeSpan.Zero;