From 317b20a0f38045c12aca22e94354199bc48484e7 Mon Sep 17 00:00:00 2001 From: Chris Kleinknecht Date: Mon, 19 Nov 2018 20:51:12 -0800 Subject: [PATCH] Remove obsolete comments, sort imports --- .../recommendation_server.py | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/recommendationservice/recommendation_server.py b/src/recommendationservice/recommendation_server.py index 9714038..eb24f96 100644 --- a/src/recommendationservice/recommendation_server.py +++ b/src/recommendationservice/recommendation_server.py @@ -14,13 +14,18 @@ # See the License for the specific language governing permissions and # limitations under the License. -import grpc -from concurrent import futures -import time -import traceback import os import random +import time +import traceback +from concurrent import futures + import googleclouddebugger +import grpc +from opencensus.trace.exporters import print_exporter +from opencensus.trace.exporters import stackdriver_exporter +from opencensus.trace.ext.grpc import server_interceptor +from opencensus.trace.samplers import always_on import demo_pb2 import demo_pb2_grpc @@ -30,11 +35,6 @@ from grpc_health.v1 import health_pb2_grpc from logger import getJSONLogger logger = getJSONLogger('recommendationservice-server') -# TODO(morganmclean,ahmetb) tracing currently disabled due to memory leak (see TODO below) -from opencensus.trace.ext.grpc import server_interceptor -from opencensus.trace.samplers import always_on -from opencensus.trace.exporters import stackdriver_exporter -from opencensus.trace.exporters import print_exporter class RecommendationService(demo_pb2_grpc.RecommendationServiceServicer): def ListRecommendations(self, request, context): @@ -63,9 +63,6 @@ class RecommendationService(demo_pb2_grpc.RecommendationServiceServicer): if __name__ == "__main__": logger.info("initializing recommendationservice") - # TODO(morganmclean,ahmetb) enabling the tracing interceptor/sampler below - # causes an unbounded memory leak eventually OOMing the container. - # ---- try: sampler = always_on.AlwaysOnSampler() exporter = stackdriver_exporter.StackdriverExporter()