respond to comments

This commit is contained in:
Megan O'Keefe 2019-12-16 09:14:07 -05:00
parent dd7d1c438b
commit 6aefa7aeb6
3 changed files with 4 additions and 12 deletions

6
.gitignore vendored
View file

@ -8,8 +8,4 @@ pkg/
.vs/ .vs/
.idea .idea
.skaffold-*.yaml .skaffold-*.yaml
.kubernetes-manifests-*/ .kubernetes-manifests-*/
istio-1.*/
install-istio.sh
mtls.yaml
istio.yaml

View file

@ -11,7 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
apiVersion: apps/v1 apiVersion: apps/v1
kind: Deployment kind: Deployment
metadata: metadata:
@ -30,9 +29,6 @@ spec:
spec: spec:
terminationGracePeriodSeconds: 5 terminationGracePeriodSeconds: 5
restartPolicy: Always restartPolicy: Always
env:
- name: FRONTEND_ADDR
value: "frontend:80"
containers: containers:
- name: main - name: main
image: loadgenerator image: loadgenerator
@ -47,4 +43,4 @@ spec:
memory: 256Mi memory: 256Mi
limits: limits:
cpu: 500m cpu: 500m
memory: 512Mi memory: 512Mi

View file

@ -18,7 +18,7 @@
set -e set -e
trap "exit" TERM trap "exit" TERM
if [ -z "${FRONTEND_ADDR}" ]; then if [[ -z "${FRONTEND_ADDR}" ]]; then
echo >&2 "FRONTEND_ADDR not specified" echo >&2 "FRONTEND_ADDR not specified"
exit 1 exit 1
fi fi
@ -28,7 +28,7 @@ set -x
# if one request to the frontend fails, then exit # if one request to the frontend fails, then exit
STATUSCODE=$(curl --silent --output /dev/stderr --write-out "%{http_code}" http://${FRONTEND_ADDR}) STATUSCODE=$(curl --silent --output /dev/stderr --write-out "%{http_code}" http://${FRONTEND_ADDR})
if test $STATUSCODE -ne 200; then if test $STATUSCODE -ne 200; then
echo "Error: cannot reach frontend, exiting" echo "Error: Could not reach frontend - Status code: ${STATUSCODE}"
exit 1 exit 1
fi fi