From 741c669c341ae5d0af2e3695fd3fd9c7dec556e2 Mon Sep 17 00:00:00 2001 From: rghetia Date: Thu, 14 Feb 2019 18:14:42 -0800 Subject: [PATCH] adservice: restore old grpc views until new grpc version is released. (#144) --- src/adservice/src/main/java/hipstershop/AdService.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/adservice/src/main/java/hipstershop/AdService.java b/src/adservice/src/main/java/hipstershop/AdService.java index 1c04f60..3c63c98 100644 --- a/src/adservice/src/main/java/hipstershop/AdService.java +++ b/src/adservice/src/main/java/hipstershop/AdService.java @@ -270,7 +270,14 @@ public final class AdService { /** Main launches the server from the command line. */ public static void main(String[] args) throws IOException, InterruptedException { // Registers all RPC views. - RpcViews.registerAllGrpcViews(); + /** + * [TODO:rghetia] replace registerAllViews with registerAllGrpcViews. + * registerAllGrpcViews registers new views using new measures however current grpc version records against + * old measures. When new version of grpc (0.19) is release revert back to new. After reverting + * back to new the new measure will not provide any tags (like method). This will create + * some discrepencies when compared grpc measurements in Go services. + */ + RpcViews.registerAllViews(); new Thread( new Runnable() {