From b61b4c929c6ea9c0ea337b4da3d6ec3f52c5fdb9 Mon Sep 17 00:00:00 2001
From: rahulpa <rahulpa@google.com>
Date: Mon, 12 Nov 2018 14:27:12 -0800
Subject: [PATCH] increase reporting interval. also fixed a bug in SD export
 registration in Ads.

---
 .../src/main/java/hipstershop/AdService.java  | 22 +++++++++++++------
 src/checkoutservice/main.go                   |  1 +
 src/frontend/main.go                          |  1 +
 src/productcatalogservice/server.go           |  1 +
 src/shippingservice/main.go                   |  1 +
 5 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/src/adservice/src/main/java/hipstershop/AdService.java b/src/adservice/src/main/java/hipstershop/AdService.java
index 9ba3329..1224efe 100644
--- a/src/adservice/src/main/java/hipstershop/AdService.java
+++ b/src/adservice/src/main/java/hipstershop/AdService.java
@@ -207,16 +207,24 @@ public class AdService {
     // Registers logging trace exporter.
     LoggingTraceExporter.register();
     long sleepTime = 10; /* seconds */
-    int maxAttempts = 3;
+    int maxAttempts = 5;
+    boolean statsExporterRegistered = false;
+    boolean traceExporterRegistered = false;
 
     for (int i=0; i<maxAttempts; i++) {
       try {
-        StackdriverTraceExporter.createAndRegister(
-            StackdriverTraceConfiguration.builder().build());
-        StackdriverStatsExporter.createAndRegister(
-            StackdriverStatsConfiguration.builder()
-                .setExportInterval(Duration.create(15, 0))
-                .build());
+        if (!traceExporterRegistered) {
+          StackdriverTraceExporter.createAndRegister(
+              StackdriverTraceConfiguration.builder().build());
+          traceExporterRegistered = true;
+        }
+        if (!statsExporterRegistered) {
+          StackdriverStatsExporter.createAndRegister(
+              StackdriverStatsConfiguration.builder()
+                  .setExportInterval(Duration.create(60, 0))
+                  .build());
+          statsExporterRegistered = true;
+        }
       } catch (Exception e) {
         if (i==(maxAttempts-1)) {
           logger.log(Level.WARN, "Failed to register Stackdriver Exporter." +
diff --git a/src/checkoutservice/main.go b/src/checkoutservice/main.go
index cbc408f..990b004 100644
--- a/src/checkoutservice/main.go
+++ b/src/checkoutservice/main.go
@@ -99,6 +99,7 @@ func main() {
 }
 
 func initStats(exporter *stackdriver.Exporter) {
+	view.SetReportingPeriod(60 * time.Second)
 	view.RegisterExporter(exporter)
 	if err := view.Register(ocgrpc.DefaultServerViews...); err != nil {
 		log.Warn("Error registering default server views")
diff --git a/src/frontend/main.go b/src/frontend/main.go
index 8939def..5046432 100644
--- a/src/frontend/main.go
+++ b/src/frontend/main.go
@@ -143,6 +143,7 @@ func main() {
 }
 
 func initStats(log logrus.FieldLogger, exporter *stackdriver.Exporter) {
+	view.SetReportingPeriod(60 * time.Second)
 	view.RegisterExporter(exporter)
 	if err := view.Register(ochttp.DefaultServerViews...); err != nil {
 		log.Warn("Error registering http default server views")
diff --git a/src/productcatalogservice/server.go b/src/productcatalogservice/server.go
index 0b8efef..a727922 100644
--- a/src/productcatalogservice/server.go
+++ b/src/productcatalogservice/server.go
@@ -90,6 +90,7 @@ func run(port int) string {
 }
 
 func initStats(exporter *stackdriver.Exporter) {
+	view.SetReportingPeriod(60 * time.Second)
 	view.RegisterExporter(exporter)
 	if err := view.Register(ocgrpc.DefaultServerViews...); err != nil {
 		log.Info("Error registering default server views")
diff --git a/src/shippingservice/main.go b/src/shippingservice/main.go
index 35f7ed4..523731c 100644
--- a/src/shippingservice/main.go
+++ b/src/shippingservice/main.go
@@ -129,6 +129,7 @@ func (s *server) ShipOrder(ctx context.Context, in *pb.ShipOrderRequest) (*pb.Sh
 }
 
 func initStats(exporter *stackdriver.Exporter) {
+	view.SetReportingPeriod(60 * time.Second)
 	view.RegisterExporter(exporter)
 	if err := view.Register(ocgrpc.DefaultServerViews...); err != nil {
 		log.Warn("Error registering default server views")