From be65dd1fcd739d48e51ff60e3267cdc6b2b878f6 Mon Sep 17 00:00:00 2001 From: Ahmet Alp Balkan Date: Fri, 28 Sep 2018 12:52:06 -0700 Subject: [PATCH] cartservice: fix health Check() method signature (#57) - Use the method provided in HealthBase - Use the same version of GrpcHealth as Grpc core. Fixes #50. --- src/cartservice/HealthImpl.cs | 10 ++++++---- src/cartservice/cartservice.csproj | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/cartservice/HealthImpl.cs b/src/cartservice/HealthImpl.cs index 5ac6551..f231c7c 100644 --- a/src/cartservice/HealthImpl.cs +++ b/src/cartservice/HealthImpl.cs @@ -1,5 +1,7 @@ using System; +using System.Threading.Tasks; using cartservice.interfaces; +using Grpc.Core; using Grpc.Health.V1; using StackExchange.Redis; using static Grpc.Health.V1.Health; @@ -11,12 +13,12 @@ namespace cartservice { this.dependency = dependency; } - public HealthCheckResponse Check (HealthCheckRequest request) { + public override Task Check(HealthCheckRequest request, ServerCallContext context){ Console.WriteLine ("Checking CartService Health"); - return new HealthCheckResponse { + return Task.FromResult(new HealthCheckResponse { Status = dependency.Ping() ? HealthCheckResponse.Types.ServingStatus.Serving : HealthCheckResponse.Types.ServingStatus.NotServing - }; + }); } } -} \ No newline at end of file +} diff --git a/src/cartservice/cartservice.csproj b/src/cartservice/cartservice.csproj index 91a1c61..3fea4a1 100644 --- a/src/cartservice/cartservice.csproj +++ b/src/cartservice/cartservice.csproj @@ -10,7 +10,7 @@ - +