From c123ff8ac016c46b6355ed873e5f79c187266f1d Mon Sep 17 00:00:00 2001
From: Steinwagner <matthias.steinwagner@sap.com>
Date: Wed, 11 Dec 2019 11:35:41 +0100
Subject: [PATCH] Update TamagotchiService.java

---
 .../java/com/sap/tamagotchi/service/TamagotchiService.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/tamagotchi-service/src/main/java/com/sap/tamagotchi/service/TamagotchiService.java b/src/tamagotchi-service/src/main/java/com/sap/tamagotchi/service/TamagotchiService.java
index 793c94f..4f22013 100644
--- a/src/tamagotchi-service/src/main/java/com/sap/tamagotchi/service/TamagotchiService.java
+++ b/src/tamagotchi-service/src/main/java/com/sap/tamagotchi/service/TamagotchiService.java
@@ -84,8 +84,8 @@ public class TamagotchiService {
                 .parallelStream()
                 .filter(device -> !device.isAlive())
                 .forEach(device -> {
-                    deviceRegistry.remove(device.getId());
                     sendTamagotchiDefunctNotifiction(device.getId());
+                    deviceRegistry.remove(device.getId());
                     LOGGER.info("{} has died", device.getId());
                 });
     }
@@ -93,6 +93,9 @@ public class TamagotchiService {
     private void sendTamagotchiDefunctNotifiction(String id) {
 
         Device device = deviceRegistry.get(id);
+        if (device == null) {
+            return;
+        }
         String defunctMessage = String.format("Tamagotchi %s of %s passed away", device.getOwner(), device.getOwner());
         DefunctNotification defunctNotification = new DefunctNotification(defunctMessage);
         try {