From ed03e4086e198c8fa609e49f565f6ccfae7226be Mon Sep 17 00:00:00 2001 From: rahulpa Date: Wed, 9 Jan 2019 14:59:27 -0800 Subject: [PATCH] fix review comments. --- src/checkoutservice/main.go | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/checkoutservice/main.go b/src/checkoutservice/main.go index b2b4315..fdf1c83 100644 --- a/src/checkoutservice/main.go +++ b/src/checkoutservice/main.go @@ -131,15 +131,7 @@ func initStats(exporter *stackdriver.Exporter) { } } -func initTracing() { - // This is a demo app with low QPS. trace.AlwaysSample() is used here - // to make sure traces are available for observation and analysis. - // In a production environment or high QPS setup please use - // trace.ProbabilitySampler set at the desired probability. - trace.ApplyConfig(trace.Config{DefaultSampler: trace.AlwaysSample()}) - - initJaegerTracing() - +func initStackDriverTracing() { // TODO(ahmetb) this method is duplicated in other microservices using Go // since they are not sharing packages. for i := 1; i <= 3; i++ { @@ -161,6 +153,11 @@ func initTracing() { log.Warn("could not initialize stackdriver exporter after retrying, giving up") } +func initTracing() { + initJaegerTracing() + initStackDriverTracing() +} + func initProfiling(service, version string) { // TODO(ahmetb) this method is duplicated in other microservices using Go // since they are not sharing packages.