vbatts/ntfy
1
0
Fork 0
Code Pull requests Activity

More TODOs, hurray

Browse source
This commit is contained in:
binwiederhier 2023-01-21 16:02:56 -05:00
parent 5310b1d48e
commit 5a7cedce95
1 changed files with 39 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
server/server.go
View file

@ -35,39 +35,51 @@ import (
) )
/* /*
TODO TODO
races: --
- v.user --> see publishSyncEventAsync() test
payments: UAT results (round 1):
- reconciliation - Security: Account re-creation leads to terrible behavior. Use user ID instead of user name for (a) visitor map, (b) messages.user column, (c) Stripe checkout session
- Account: Changing password should confirm the old password (Thorben)
- Signup: Re-add password confirmation (Thorben & deadcade)
- Reservation: Kill existing subscribers when topic is reserved (deadcade)
- Reservation (UI): Show "This topic is reserved" error message when trying to reserve a reserved topic (Thorben)
- Reservation (UI): Ask for confirmation when removing reservation (deadcade)
delete messages + reserved topics on ResetTier delete attachments in access.go races:
account deletion should delete messages and reservations and attachments - v.user --> see publishSyncEventAsync() test
Limits & rate limiting: payments:
rate limiting weirdness. wth is going on? - reconciliation
bandwidth limit must be in tier
users without tier: should the stats be persisted? are they meaningful? -> test that the visitor is based on the IP address!
login/account endpoints
when ResetStats() is run, reset messagesLimiter (and others)?
Delete visitor when tier is changed to refresh rate limiters
Make sure account endpoints make sense for admins delete messages + reserved topics on ResetTier delete attachments in access.go
account deletion should delete messages and reservations and attachments
UI: Limits & rate limiting:
- reservation icons rate limiting weirdness. wth is going on?
- reservation table delete button: dialog "keep or delete messages?" bandwidth limit must be in tier
- flicker of upgrade banner users without tier: should the stats be persisted? are they meaningful? -> test that the visitor is based on the IP address!
- JS constants login/account endpoints
Sync: when ResetStats() is run, reset messagesLimiter (and others)?
- sync problems with "deleteAfter=0" and "displayName=" Delete visitor when tier is changed to refresh rate limiters
Tests: Make sure account endpoints make sense for admins
- Payment endpoints (make mocks)
- Message rate limiting and reset tests
- Bandwidth limit test UI:
- test that the visitor is based on the IP address when a user has no tier -
- reservation icons
- reservation table delete button: dialog "keep or delete messages?"
- flicker of upgrade banner
- JS constants
Sync:
- sync problems with "deleteAfter=0" and "displayName="
Tests:
- Payment endpoints (make mocks)
- Message rate limiting and reset tests
- Bandwidth limit test
- test that the visitor is based on the IP address when a user has no tier
*/ */
// Server is the main server, providing the UI and API for ntfy // Server is the main server, providing the UI and API for ntfy