vbatts/ntfy
1
0
Fork 0
Code Pull requests Activity

Changelog

Browse source
This commit is contained in:
binwiederhier 2022-12-12 09:55:17 -05:00
parent 40aadbad85
commit 67221b015d
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/releases.md
View file

@ -7,10 +7,12 @@ and the [ntfy Android app](https://github.com/binwiederhier/ntfy-android/release
**Features:** **Features:**
* Web: Generate random topic name button ([#453](https://github.com/binwiederhier/ntfy/issues/453), thanks to [@yardenshoham](https://github.com/yardenshoham)) * Web: Generate random topic name button ([#453](https://github.com/binwiederhier/ntfy/issues/453), thanks to [@yardenshoham](https://github.com/yardenshoham))
* Add [Gitpod config](https://github.com/binwiederhier/ntfy/blob/main/.gitpod.yml) ([#540](https://github.com/binwiederhier/ntfy/pull/540), thanks to [@yardenshoham](https://github.com/yardenshoham))
**Bug fixes + maintenance:** **Bug fixes + maintenance:**
* Remove `--env-topic` option from `ntfy publish` as per [deprecation](deprecations.md) (no ticket) * Remove `--env-topic` option from `ntfy publish` as per [deprecation](deprecations.md) (no ticket)
* Prepared statements for message cache writes ([#542](https://github.com/binwiederhier/ntfy/pull/542), thanks to [@nicois](https://github.com/nicois))
## ntfy Android app v1.16.0 ## ntfy Android app v1.16.0
Released December 11, 2022 Released December 11, 2022

9
server/message_cache.go
View file

@ -267,14 +267,11 @@ func (c *messageCache) addMessages(ms []*message) error {
return err return err
} }
defer tx.Rollback() defer tx.Rollback()
statement, err := tx.Prepare( stmt, err := tx.Prepare(insertMessageQuery)
insertMessageQuery,
)
if err != nil { if err != nil {
return err return err
} }
defer statement.Close() defer stmt.Close()
for _, m := range ms { for _, m := range ms {
if m.Event != messageEvent { if m.Event != messageEvent {
return errUnexpectedMessageType return errUnexpectedMessageType
@ -302,7 +299,7 @@ func (c *messageCache) addMessages(ms []*message) error {
if m.Sender.IsValid() { if m.Sender.IsValid() {
sender = m.Sender.String() sender = m.Sender.String()
} }
_, err := statement.Exec( _, err := stmt.Exec(
m.ID, m.ID,
m.Time, m.Time,
m.Topic, m.Topic,