"Fix" data race
This commit is contained in:
parent
edfc1b78a1
commit
ed9d99fd57
1 changed files with 7 additions and 0 deletions
|
@ -798,6 +798,13 @@ func (s *Server) handleSubscribeHTTP(w http.ResponseWriter, r *http.Request, v *
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
var wlock sync.Mutex
|
var wlock sync.Mutex
|
||||||
|
defer func() {
|
||||||
|
// Hack: This is the fix for a horrible data race that I have not been able to figure out in quite some time.
|
||||||
|
// It appears to be happening when the Go HTTP code reads from the socket when closing the request (i.e. AFTER
|
||||||
|
// this function returns), and causes a data race with the ResponseWriter. Locking wlock here silences the
|
||||||
|
// data race detector. See https://github.com/binwiederhier/ntfy/issues/338#issuecomment-1163425889.
|
||||||
|
wlock.TryLock()
|
||||||
|
}()
|
||||||
sub := func(v *visitor, msg *message) error {
|
sub := func(v *visitor, msg *message) error {
|
||||||
if !filters.Pass(msg) {
|
if !filters.Pass(msg) {
|
||||||
return nil
|
return nil
|
||||||
|
|
Loading…
Reference in a new issue