vbatts/pkg
1
0
Fork 0
Code Pull requests Releases Activity

Merge pull request #16642 from vdemeester/remove-question-make-in-pkg-devicemapper

Browse source 
Remove "(?)" from comments in pkg/devicemapper
This commit is contained in:
Brian Goff 2015-09-30 09:39:23 -04:00
commit 0a8a14a5fc
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
devicemapper/devmapper.go
View file

@ -109,7 +109,7 @@ type (
}
// TaskType represents a type of task
TaskType int
// AddNodeType represents a type of node to be added (?)
// AddNodeType represents a type of node to be added
AddNodeType int
)
@ -309,7 +309,7 @@ func FindLoopDeviceFor(file *os.File) *os.File {
return nil
}
// UdevWait wakes any processes that are waiting for udev to complete the specified cookie. (?)
// UdevWait waits for any processes that are waiting for udev to complete the specified cookie.
func UdevWait(cookie *uint) error {
if res := DmUdevWait(*cookie); res != 1 {
logrus.Debugf("Failed to wait on udev cookie %d", *cookie)
@ -318,7 +318,7 @@ func UdevWait(cookie *uint) error {
return nil
}
// LogInitVerbose is an interface to initialize the verbose logger for the device mapper library. (?)
// LogInitVerbose is an interface to initialize the verbose logger for the device mapper library.
func LogInitVerbose(level int) {
DmLogInitVerbose(level)
}
@ -706,7 +706,7 @@ func ResumeDevice(name string) error {
return nil
}
// CreateDevice creates a device with the specified poolName with the specified device id. (?)
// CreateDevice creates a device with the specified poolName with the specified device id.
func CreateDevice(poolName string, deviceID int) error {
logrus.Debugf("[devmapper] CreateDevice(poolName=%v, deviceID=%v)", poolName, deviceID)
task, err := TaskCreateNamed(deviceTargetMsg, poolName)
@ -735,7 +735,7 @@ func CreateDevice(poolName string, deviceID int) error {
return nil
}
// DeleteDevice deletes a device with the specified poolName with the specified device id. (?)
// DeleteDevice deletes a device with the specified poolName with the specified device id.
func DeleteDevice(poolName string, deviceID int) error {
task, err := TaskCreateNamed(deviceTargetMsg, poolName)
if task == nil {
@ -763,7 +763,7 @@ func ActivateDevice(poolName string, name string, deviceID int, size uint64) err
}
// ActivateDeviceWithExternal activates the device identified by the specified
// poolName, name and deviceID with the specified size. (?)
// poolName, name and deviceID with the specified size.
func ActivateDeviceWithExternal(poolName string, name string, deviceID int, size uint64, external string) error {
return activateDevice(poolName, name, deviceID, size, external)
}

2
devicemapper/devmapper_log.go
View file

@ -11,7 +11,7 @@ import (
// Due to the way cgo works this has to be in a separate file, as devmapper.go has
// definitions in the cgo block, which is incompatible with using "//export"
// DevmapperLogCallback exports the devmapper log callback for cgo. (?)
// DevmapperLogCallback exports the devmapper log callback for cgo.
//export DevmapperLogCallback
func DevmapperLogCallback(level C.int, file *C.char, line C.int, dmErrnoOrClass C.int, message *C.char) {
msg := C.GoString(message)

4
devicemapper/devmapper_wrapper.go
View file

@ -77,7 +77,7 @@ const (
LoopSetCapacity = C.LOOP_SET_CAPACITY
)
// LOOP consts. (?)
// LOOP consts.
const (
LoFlagsAutoClear = C.LO_FLAGS_AUTOCLEAR
LoFlagsReadOnly = C.LO_FLAGS_READ_ONLY
@ -86,7 +86,7 @@ const (
LoNameSize = C.LO_NAME_SIZE
)
// DeviceMapper Udev consts. (?)
// Devicemapper cookie flags.
const (
DmUdevDisableSubsystemRulesFlag = C.DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG
DmUdevDisableDiskRulesFlag = C.DM_UDEV_DISABLE_DISK_RULES_FLAG