vbatts/pkg
1
0
Fork 0
Code Pull requests Releases Activity

pkg/tarsum: fix panic with dynamic buffer

Browse source 
When read is called on a tarsum with a two different read sizes, specifically the second call larger than the first, the dynamic buffer does not get reallocated causing a slice read error.

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
This commit is contained in:
Derek McGowan 2014-09-25 15:58:35 -07:00
parent 56483ba9b4
commit 6a33e70bd5
2 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tarsum/tarsum_test.go
View file

@ -274,6 +274,22 @@ func TestTarSums(t *testing.T) {
t.Errorf("%q :: %q", err, layer.filename)
continue
}
// Read variable number of bytes to test dynamic buffer
dBuf := make([]byte, 1)
_, err = ts.Read(dBuf)
if err != nil {
t.Errorf("failed to read 1B from %s: %s", layer.filename, err)
continue
}
dBuf = make([]byte, 16*1024)
_, err = ts.Read(dBuf)
if err != nil {
t.Errorf("failed to read 16KB from %s: %s", layer.filename, err)
continue
}
// Read and discard remaining bytes
_, err = io.Copy(ioutil.Discard, ts)
if err != nil {
t.Errorf("failed to copy from %s: %s", layer.filename, err)