vbatts/pkg
1
0
Fork 0
Code Pull requests Releases Activity

cgroups: Join groups by writing to cgroups.procs, not tasks

Browse source 
cgroups.procs moves all the threads of the process, and "tasks" just
the one thread. I believe there is a risk that we move the main thread,
but then we accidentally fork off one of the other threads if the go
scheduler randomly switched to another thread. So, it seems safer (and
more correct) to use cgroups.procs.

Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
This commit is contained in:
Alexander Larsson 2014-03-14 11:45:29 +01:00
parent fce532280b
commit 7cd539bc3d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cgroups/apply_raw.go
View file

@ -68,7 +68,7 @@ func (raw *rawCgroup) join(subsystem string, pid int) (string, error) {
if err := os.MkdirAll(path, 0755); err != nil && !os.IsExist(err) { if err := os.MkdirAll(path, 0755); err != nil && !os.IsExist(err) {
return "", err return "", err
} }
if err := writeFile(path, "tasks", strconv.Itoa(pid)); err != nil { if err := writeFile(path, "cgroup.procs", strconv.Itoa(pid)); err != nil {
return "", err return "", err
} }
return path, nil return path, nil