vbatts/pkg
1
0
Fork 0
Code Pull requests Releases Activity

Fix for zero-sized layers

Browse source 
Moved a defer up to a better spot.

Fixed TestUntarPathWithInvalidDest to actually fail for the right reason

Closes #18170

Signed-off-by: Doug Davis <dug@us.ibm.com>
This commit is contained in:
Doug Davis 2015-11-23 17:20:44 -08:00
parent 5ca1b7ff65
commit baafebd598
2 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
archive/archive.go
View file

@ -128,7 +128,13 @@ func DecompressStream(archive io.Reader) (io.ReadCloser, error) {
p := pools.BufioReader32KPool
buf := p.Get(archive)
bs, err := buf.Peek(10)
if err != nil {
if err != nil && err != io.EOF {
// Note: we'll ignore any io.EOF error because there are some odd
// cases where the layer.tar file will be empty (zero bytes) and
// that results in an io.EOF from the Peek() call. So, in those
// cases we'll just treat it as a non-compressed stream and
// that means just create an empty layer.
// See Issue 18170
return nil, err
}

11
archive/archive_test.go
View file

@ -216,11 +216,16 @@ func TestUntarPathWithInvalidDest(t *testing.T) {
invalidDestFolder := path.Join(tempFolder, "invalidDest")
// Create a src file
srcFile := path.Join(tempFolder, "src")
_, err = os.Create(srcFile)
tarFile := path.Join(tempFolder, "src.tar")
os.Create(srcFile)
os.Create(invalidDestFolder) // being a file (not dir) should cause an error
cmd := exec.Command("/bin/sh", "-c", "tar cf "+tarFile+" "+srcFile)
_, err = cmd.CombinedOutput()
if err != nil {
t.Fatalf("Fail to create the source file")
t.Fatal(err)
}
err = UntarPath(srcFile, invalidDestFolder)
err = UntarPath(tarFile, invalidDestFolder)
if err == nil {
t.Fatalf("UntarPath with invalid destination path should throw an error.")
}