vbatts/pkg
1
0
Fork 0
Code Pull requests Releases Activity

Do not hardcode http as plugin URL scheme for secure connections.

Browse source 
Signed-off-by: David Calavera <david.calavera@gmail.com>
This commit is contained in:
David Calavera 2015-09-22 15:54:29 -04:00
parent c8e890aa4b
commit f624804e8f
2 changed files with 26 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
plugins/client_test.go
View file

@ -105,3 +105,19 @@ func TestAbortRetry(t *testing.T) {
}
}
}
func TestClientScheme(t *testing.T) {
cases := map[string]string{
"tcp://127.0.0.1:8080": "http",
"unix:///usr/local/plugins/foo": "http",
"http://127.0.0.1:8080": "http",
"https://127.0.0.1:8080": "https",
}
for addr, scheme := range cases {
c, _ := NewClient(addr, tlsconfig.Options{InsecureSkipVerify: true})
if c.scheme != scheme {
t.Fatalf("URL scheme mismatch, expected %s, got %s", scheme, c.scheme)
}
}
}