a513a8b8e0
As reported in #11294, the Docker daemon will execute contains it shouldn't run in the event that a requested tag is present in an image's ID. This leads to the wrong image being started up silently. This change reduces the risk of such a collision by using the short ID iff the actual revOrTag looks like a short ID (not that it necessarily is). Signed-off-by: Richard Burnison <rburnison@ebay.com>
56 lines
1.1 KiB
Go
56 lines
1.1 KiB
Go
package stringid
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestGenerateRandomID(t *testing.T) {
|
|
id := GenerateRandomID()
|
|
|
|
if len(id) != 64 {
|
|
t.Fatalf("Id returned is incorrect: %s", id)
|
|
}
|
|
}
|
|
|
|
func TestShortenId(t *testing.T) {
|
|
id := GenerateRandomID()
|
|
truncID := TruncateID(id)
|
|
if len(truncID) != 12 {
|
|
t.Fatalf("Id returned is incorrect: truncate on %s returned %s", id, truncID)
|
|
}
|
|
}
|
|
|
|
func TestShortenIdEmpty(t *testing.T) {
|
|
id := ""
|
|
truncID := TruncateID(id)
|
|
if len(truncID) > len(id) {
|
|
t.Fatalf("Id returned is incorrect: truncate on %s returned %s", id, truncID)
|
|
}
|
|
}
|
|
|
|
func TestShortenIdInvalid(t *testing.T) {
|
|
id := "1234"
|
|
truncID := TruncateID(id)
|
|
if len(truncID) != len(id) {
|
|
t.Fatalf("Id returned is incorrect: truncate on %s returned %s", id, truncID)
|
|
}
|
|
}
|
|
|
|
func TestIsShortIDNonHex(t *testing.T) {
|
|
id := "some non-hex value"
|
|
if IsShortID(id) {
|
|
t.Fatalf("%s is not a short ID", id)
|
|
}
|
|
}
|
|
|
|
func TestIsShortIDNotCorrectSize(t *testing.T) {
|
|
id := strings.Repeat("a", shortLen+1)
|
|
if IsShortID(id) {
|
|
t.Fatalf("%s is not a short ID", id)
|
|
}
|
|
id = strings.Repeat("a", shortLen-1)
|
|
if IsShortID(id) {
|
|
t.Fatalf("%s is not a short ID", id)
|
|
}
|
|
}
|